Repository navigation
Unify USD loading through import recipes and authored scene semantics - #795
Conversation
[Medium impact] The reviewed changes appear safe to merge; the previous replacement bug is fixed and no new blocking issue was established. SummaryUSD loading now shares
|
han-xudong
left a comment
There was a problem hiding this comment.
The existing preserve config regression and the offset reuse issue can silently change simulation behavior. The inline comments include reproduction details for the remaining P1 and P2 findings. The offset issue is tracked in the existing Greptile thread. Offset reuse discussion
Local validation on Python 3.12.14 and DexSim 0.6.0rc1 passed 518 focused tests, two native binding and reset tests, two GenSim offscreen texture tests, and four Newton/CUDA deformable smoke cases. The targeted reproductions cover additional paths beyond that passing set.
han-xudong
left a comment
There was a problem hiding this comment.
Requesting changes on c6982f84 for the three remaining regressions. The two inline comments cover explicit zero placement and procedural defaults. The returned .cfg issue is tracked in the existing Greptile discussion. Offset reuse discussion
CI. The Python 3.11 fast lane reported 12,967 passed, 1 failed, and 51 skipped. test_sparse_override_keeps_actor_and_pose_and_remaps_constraint fails with AttributeError: 'ConstraintDesc' object has no attribute 'usd', which also fails the test gate. The fixture replaces dexsim.spawn.ConstraintDesc after usd_import can already have bound the real class. The fake then passes through the constraint filter and lacks usd. I reproduced the same failure locally by importing embodichain.lab.sim.spawn.usd_import before running the single test. Using a real SDK constraint descriptor would remove this dependency on import order. CI log
Local verification. On Python 3.12.14 and DexSim 0.6.0rc1, 515 focused tests and four native binding, reset, and replacement cases passed. Separate native Default CPU probes using replace_rigid_object(asset.cfg.copy()) still changed x from 3 to 5 for a singleton offset import and from 3 to 2 for a translated scene import. The inline comments include the previous-head and current-head results for the other two regressions.
han-xudong
left a comment
There was a problem hiding this comment.
Follow-up review of 7283a95 against 1070fcd. I checked the fixes for explicit zero placement, ordinary mesh defaults, and reuse of returned facade configs. The isolated follow-up run passed 265 configuration and import tests and 15 acceptance-runner tests. The inline comments record three remaining P2 issues and two P3 issues, each verified with a focused probe. The current GitHub build and test jobs were still pending at the time of review.
han-xudong
left a comment
There was a problem hiding this comment.
LGTM. Thanks for addressing the review feedback. Please resolve the merge conflicts with main and make sure the failing CI checks pass before merging.
Description
USD imports now use one recipe,
SimulationManager.add_usd(UsdImportCfg(...)), and return stable source-path mappings throughUsdImportResult. This resolves duplicated source-file ownership and binds imported soft bodies and cloth into the existing EmbodiChain lifecycle.UsdSourceCfg; namespace, scene placement and sparse asset overrides belong toUsdImportCfg. Typed overrides retain their class and unset-placement semantics when serialized.prepare()and does not promise rollback.add_usd(name, file_path, ...)calls retain their mutable dictionary return. Source-address compatibility spellings remain supported.460939c83and use its pinned DexSim0.6.0rc1contract, preserving the native DexUni default.Validation
Latest five review follow-ups (2026-11-10)
Fixed in
52896be4c5285513993a522659aecc84a61cb7e7:<prim_path>#<ordinal>, withresource_source_pathsretaining the exact prim path. UID/type/source maps and constraint subsets share the same key assignment.Validation: 737 related tests, 126 robot configuration tests, 6 native USD binding/reset/replacement cases, 11 GenSim USD tests, 42 context tests, and 11 API-checker tests passed. Black 26.10.1 and API coverage 4672/4672 passed. A real one/two-curve USD fixture checks complete/stable resource metadata across namespace variants; cable physics recertification and the historical 54-input asset matrix were not rerun. The independent API review confirmed both result/serialization fixes, and public docs/context now describe derived resource keys.
Remote CI for this head is pending; local validation is reported separately.
URDF scale CI regression fix (2026-11-10)
body_scale=None.(1, 1, 1). Explicit scale and USD source-scale preservation are unaffected. Regression coverage includes both ArticulationCfg and RobotCfg with omitted and non-unit scale.1070fcdc4to clear the PR merge conflict and restore CI triggering. After merging: 412 focused tests, the same 6 native cases, and API coverage 4672/4672 pass. Fresh remote CI is pending.Latest follow-up review and CI fix (2026-11-09)
configmode. Original caller configs retain their input intent. Reusingasset.cfg.copy()preserves singleton offsets and whole-scene placement across repeated replacement/reset, including the legacy scene API.usd_importbefore running the complete override module passes 30 tests.Latest PR feedback and CI fixes (2026-11-09)
overlay. Restored positional config compatibility and aligned sparse/typed Euler conversion.Greptile review fixes (2026-11-09)
Fixed all five findings in
ee3ffceda0b0cabaeeda81a525479a18928edd45:init_local_pose=Noneacross singleton USD config round trips.Validation: 583 affected tests, 11 GenSim USD tests, and 2 native binding/reset regressions passed on Python 3.12.16 / DexSim 0.6.0rc1. Black 26.10.1, context validation and API documentation coverage 4438/4438 passed. Existing source/descriptor tests were reused; focused additions cover the reported config, registry, native reset, retry and acceptance-runner gaps. Context guidance already documents authored placement and pre-declaration validation, so no prose changes were needed.
Latest main synchronization (2026-11-09)
mainat460939c83; merge commit16ca62a338830bcc53fc870a347e1dc2369b0143.Initial asset acceptance (2026-11-07)
Committed acceptance report
dexsim_engine==0.6.0+c3e92584a3dc31479ad07cb1a3551965077109e6on an RTX 5090. Entry-file SHA256 values remained unchanged. The suite covers the six non-3DGS document categories and all 10 cached EmbodiChain USD entry points (10/10 passed).test_backend_property_groups_track_dexsim_spawn_descriptors). That schema gap is resolved by main's DexSim migration (Adapt EmbodiChain to DexSim 0.6.0rc1 on Python 3.12 #1124), and the check passes in the latest synchronization run above.Acceptance covers loading, facade binding, finite simulation state, stepping/reset and selected offscreen views. Profile recertification and reference-based appearance-fidelity comparison were outside this run.
Type of change
Checklist
black .before each commit.