Repository navigation
fix(windows): preserve worker recovery errors - #2282
Conversation
Signed-off-by: News <knewstimek@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Merged — thank you, @knewstimek. Running out of We confirmed it in both directions on our Windows ARM64 VM before merging:
Two small follow-ups, neither a blocker:
Thank you again for the careful Windows work. |
Fix Windows worker recovery after retained logs exhaust
_wmktemp's small name space.cbm_mkstempnow draws a random six-digit suffix and opens the file exclusively. If recovery setup fails, the original worker outcome remains the reported error. Artifact creation also logs its errno.The Windows regression test retains 64 files from one template. It fails before this change, when
_wmktempruns out of names, and passes with the fix.Split from #2268. No encoding or compile database changes.