Repository navigation
fix(windows): preserve mkstemp errors through cleanup - #2362
Conversation
Signed-off-by: News <knewstimek@users.noreply.github.com>
|
Thanks for opening this — it has been seen, and it is queued. This note is automated, but it is not a brush-off: it exists so you know where your PR stands instead of having to guess from silence. Current review status: working through a backlog. What that means for this PR, concretely:
Things that will genuinely speed it up whenever review does happen:
If this fixes a bug, a reproduction we can run is worth more than a description of the symptom. Thanks for contributing, and sorry in advance for the wait. |
|
Merged. Thank you, @knewstimek, for following up on the #2282 review so quickly! |
When
_wopenfails, cleanup can overwriteerrnobeforecbm_mkstempchecks whether to retry or returns the error. Save the error immediately and restore it after cleanup; preserve random-generation and path-conversion failures as well.Follow-up to #2282.
Validation on Windows x64: the retained-file and non-ASCII-directory tests pass. A focused harness makes cleanup overwrite
errno: the original code returns EIO instead of ENOENT for a missing parent directory, while this change preserves ENOENT.