DiffEq -- Only context

[blt]

Summary

Change Type

• Bug fix
• New feature
• Non-functional (chore, refactoring, docs)
• Performance

How did you test this PR?

References

[blt]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• DiffEq -- Only context #1891 👈 (View in Graphite)
• chore(antithesis): Expand cheap-win antithesis SDK assertions #1930
• chore(antithesis): Migrate Antithesis SDK to saluki-antithesis #1928
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[datadog-datadog-prod-us1-2]

✨ Fix all issues with BitsAI

⚠️ Warnings

🚦 5 Pipeline jobs failed

DataDog/saluki | check-unused-deps     

Copilot | copilot-pull-request-reviewer     

DataDog/saluki | unit-tests-macos-arm64     

View all 5 failed jobs.

Useful? React with 👍 / 👎

_{This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a1f5395 | Docs | Datadog PR Page | Give us feedback!}

[pr-commenter]

Binary Size Analysis (Agent Data Plane)

Baseline: da59d73 · Comparison: a1f5395 · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.55 MiB (baseline) vs 40.56 MiB (comparison)
Size Change: +13.71 KiB (+0.03%)

✅ Binary size difference within threshold

Changes by Module

Module	File Size	Symbols
anon.c631d4f28c2b2db28eff0b5e986a13c9.248.llvm.11665572444932606208	-16.70 KiB	1
anon.a873801c7d344698c7e141ea568eb541.8.llvm.772909932056020429	+16.69 KiB	1
datadog_protos::trace_piecemeal_include::datadog	+15.48 KiB	21
anon.661ef608d0e9e2423c9230617f2bc873.62.llvm.10199967635082326453	-15.25 KiB	1
anon.b3e0eab197798cc0da9737cc7a4b2b55.357.llvm.10946300965617976101	+15.24 KiB	1
anon.a9030c24ed0837a8b572f3c7e56188a8.26.llvm.9410433398480454732	-13.82 KiB	1
anon.1189445ec7eff1270e7dd0f17e2d5ca2.250.llvm.17306377180053584343	+13.81 KiB	1
piecemeal	-13.47 KiB	43
figment	+10.59 KiB	666
anon.9890a1e0c5f52a6438e911161778df39.22.llvm.7770142864409893306	+9.29 KiB	1
anon.da384e72d3643b966148975fcb09a882.6.llvm.13854863512543145371	-9.29 KiB	1
anon.8b65035d13c51f32b9d728cce5f56d57.99.llvm.11465485835199057852	-8.68 KiB	1
anon.037b73375b9db328fde26158632bc3f6.163.llvm.6585120399213736597	+8.59 KiB	1
tokio	+7.83 KiB	5106
anon.4c31535843da9b7b5c410466b0ae9c40.167.llvm.1741467634674709001	-7.77 KiB	1
serde	-7.71 KiB	118
anon.a7a5ac420a821b949ace2821d7829b69.112.llvm.4013872591714255300	+7.68 KiB	1
anon.eb45231a870a0b6df1e2d8e973842c5f.3.llvm.484420335341077042	+7.38 KiB	1
anon.c328b6f354cc1b1d6fbd54244a9fedaa.25.llvm.11162780902400196661	-7.29 KiB	1
saluki_io::net::util	+6.79 KiB	181

Detailed Symbol Changes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +54.5Ki  [NEW] +54.3Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::ha9e4e51eec0304f6
  [NEW] +39.8Ki  [NEW] +39.7Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h4d95df7d046da704
  [NEW] +39.7Ki  [NEW] +39.5Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::hc188f44480c77627
  [NEW] +33.7Ki  [NEW] +33.5Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::had2e01dc3fa09af5
  [NEW] +30.4Ki  [NEW] +30.3Ki    agent_data_plane::cli::dogstatsd::handle_dogstatsd_command::_{{closure}}::h02653f5b83fc945f
  [NEW] +28.3Ki  [NEW] +28.1Ki    saluki_components::sources::otlp::metrics::translator::OtlpMetricsTranslator::translate_metrics::h562b182282594846
  [NEW] +25.4Ki  [NEW] +25.1Ki    _<saluki_components::sources::dogstatsd::_::<impl serde_core::de::Deserialize for saluki_components::sources::dogstatsd::DogStatsDConfiguration>::deserialize::__Visitor as serde_core::de::Visitor>::visit_map::h20277497ec1c98a7
  [NEW] +25.1Ki  [NEW] +24.9Ki    core::ptr::drop_in_place<agent_data_plane::cli::run::handle_run_command::{{closure}}>::h49a3ec78d95db62f
  [NEW] +25.0Ki  [NEW] +24.9Ki    saluki_components::sources::dogstatsd::drive_stream::_{{closure}}::h7afc200a0fa1e01e
  [NEW] +24.5Ki  [NEW] +24.3Ki    agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::_{{closure}}::ha578ddde22e2de13
  [NEW] +24.2Ki  [NEW] +24.0Ki    saluki_env::workload::collectors::containerd::NamespaceWatcher::build_initial_metadata_operations::_{{closure}}::h2f94705b93f853e1
  [DEL] -24.5Ki  [DEL] -24.3Ki    agent_data_plane::internal::remote_agent::run_remote_agent_registration_loop::_{{closure}}::hcf083b5830259c14
  [DEL] -25.0Ki  [DEL] -24.9Ki    saluki_components::sources::dogstatsd::drive_stream::_{{closure}}::h4618b6207a99eb2b
  [DEL] -25.1Ki  [DEL] -24.9Ki    core::ptr::drop_in_place<agent_data_plane::cli::run::handle_run_command::{{closure}}>::h9f679e5a6425f93c
  [DEL] -28.3Ki  [DEL] -28.2Ki    saluki_components::sources::otlp::metrics::translator::OtlpMetricsTranslator::translate_metrics::h6032372c5d685c9d
  [DEL] -30.4Ki  [DEL] -30.3Ki    agent_data_plane::cli::dogstatsd::handle_dogstatsd_command::_{{closure}}::hd47e947b534c018e
  [DEL] -33.7Ki  [DEL] -33.5Ki    _<saluki_components::transforms::aggregate::Aggregate as saluki_core::components::transforms::Transform>::run::_{{closure}}::hb4a84cbbc21a072f
  -0.2% -35.9Ki  -0.2% -37.3Ki    [55991 Others]
  [DEL] -39.8Ki  [DEL] -39.7Ki    agent_data_plane::cli::run::handle_run_command::_{{closure}}::h772878347210b56d
  [DEL] -40.0Ki  [DEL] -39.8Ki    _<saluki_components::forwarders::otlp::OtlpForwarder as saluki_core::components::forwarders::Forwarder>::run::_{{closure}}::h622a7084ee8b9e54
  [DEL] -54.3Ki  [DEL] -54.1Ki    saluki_components::common::datadog::io::run_endpoint_io_loop::_{{closure}}::h2c37bd2f0a7c3fc7
  +0.0% +13.7Ki  +0.0% +11.8Ki    TOTAL

[pr-commenter]

Regression Detector (Agent Data Plane)

Run ID: f8530d6d-e49e-4502-995b-8a763d59c12c
Baseline: da59d73b · Comparison: a1f53956 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment	goal	Δ mean %	links
quality_gates_rss_dsd_medium	memory	⚪ -0.01	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory	⚪ -0.02	metrics profiles logs
quality_gates_rss_dsd_low	memory	⚪ -0.15	metrics profiles logs
quality_gates_rss_idle	memory	⚪ -0.27	metrics profiles logs
quality_gates_rss_dsd_heavy	memory	⚪ -0.35	metrics profiles logs

Bounds Checks: ✅ Passed (5)

experiment	check	replicates	observed	links
quality_gates_rss_dsd_heavy	memory_usage	10/10	✅ 131 MiB ≤ 140 MiB	metrics profiles logs
quality_gates_rss_dsd_low	memory_usage	10/10	✅ 42.4 MiB ≤ 50 MiB	metrics profiles logs
quality_gates_rss_dsd_medium	memory_usage	10/10	✅ 64.2 MiB ≤ 75 MiB	metrics profiles logs
quality_gates_rss_dsd_ultraheavy	memory_usage	10/10	✅ 192 MiB ≤ 200 MiB	metrics profiles logs
quality_gates_rss_idle	memory_usage	10/10	✅ 28.1 MiB ≤ 40 MiB	metrics profiles logs

Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.