enhancement(antithesis): Move antithesis/deploy to scenarios/general (#1890)

## Summary

I am slowly developing a House Style for `test/antithesis`. The next PR in this stack as of this writing -- #1891 -- introduces a new scenario with a new topology. Organizationally this means we have a 'general' scenario in this project already and my intention is to make a new scenario to differentially test Datadog Agent and ADP. There will be several PRs in a chain to reach a satisfying spot with that work. 

There's no functional change in this PR, just some code movement. 

<!-- Please provide a brief summary about what this PR does.
This should help the reviewers give feedback faster and with higher quality. -->

## Change Type
- [ ] Bug fix
- [ ] New feature
- [ ] Non-functional (chore, refactoring, docs)
- [ ] Performance


## How did you test this PR?
<!-- Please how you tested these changes here -->

## References

<!-- Please list any issues closed by this PR. -->

<!--
- Closes: <issue link>
-->

<!-- Any other issues or PRs relevant to this PR? Feel free to list them here. -->

Author: blt

Cargo.lock

@@ -34,6 +34,7 @@ members = [
   "lib/stringtheory",
   "test/antithesis/harness",
   "test/antithesis/intake",
+  "test/antithesis/scenarios/general",
 ]
 resolver = "2"
 

Cargo.toml

@@ -751,7 +751,7 @@ endif
 
 ##@ Antithesis
 
-ANTITHESIS_CONFIG_DIR := test/antithesis/deploy
+ANTITHESIS_CONFIG_DIR := test/antithesis/scenarios/general
 ANTITHESIS_COMPOSE_FILE := $(ANTITHESIS_CONFIG_DIR)/docker-compose.yaml
 
 .PHONY: check-antithesis-tools

Makefile

@@ -10,7 +10,7 @@ Antithesis runs — do not run `snouty launch` directly.
 
 **snouty launch**
 
-Use `snouty launch --json --webhook basic_test --config test/antithesis/deploy`
+Use `snouty launch --json --webhook basic_test --config test/antithesis/scenarios/general`
 to start an Antithesis run. Always run `compose build` first to ensure images
 are up to date.
 
@@ -27,16 +27,18 @@ testing. Antithesis will not run any test commands until it receives this event.
 
 **Directory layout**
 
-- `harness/` — the harness Rust crate (`harness`), a member of the
-  repository-root workspace. `src/lib.rs` holds shared helpers; each
-  `src/bin/*.rs` is an Antithesis test command named after its file. Run cargo
-  from this directory; it is built, fmt'd, Clippy'd, and tested from the repo
-  root via the usual `make check-all` / `make test`.
-- `deploy/` — all Antithesis/Docker infrastructure: the `Dockerfile`,
+- `harness/` — the shared harness Rust crate (`harness`), a member of the
+  repository-root workspace. `src/lib.rs` holds shared helpers and `src/bin/`
+  holds test commands reused across scenarios. Run cargo from this directory;
+  it is built, fmt'd, Clippy'd, and tested from the repo root via the usual
+  `make check-all` / `make test`.
+- `scenarios/general/` — all Antithesis/Docker infrastructure: the `Dockerfile`,
   `docker-compose.yaml`, and per-container build inputs grouped by service
-  (`deploy/adp/`, `deploy/workload/`). This is the directory snouty consumes as
-  `--config`; it contains `docker-compose.yaml` at its top. Snouty will push
-  tagged images, consume this directory, and launch the run.
+  (`scenarios/general/adp/`, `scenarios/general/workload/`). This is the directory snouty consumes as
+  `--config`; it contains `docker-compose.yaml` at its top. Its Cargo package
+  (`antithesis-scenario-general`) owns general-only test commands under
+  `src/bin/`. Snouty will push tagged images, consume this directory, and
+  launch the run.
 
 **scratchbook**
 
@@ -46,7 +48,7 @@ per-property evidence files (in `scratchbook/properties/`), property
 relationship maps, and other persistent integration notes. Keep it up to date as
 Antithesis-related decisions change.
 
-**test templates** (`deploy/workload/test/`)
+**test templates** (`scenarios/general/workload/test/`)
 
 This directory contains test templates. A test template is a directory
 containing test command executable files. Each test command must have a valid

test/antithesis/AGENTS.md

@@ -33,7 +33,7 @@ mod unix_check {
         adp_api_addr: String,
         #[arg(
             long = "dsd-socket",
-            env = "DSD_SOCKET",
+            env = "ADP_DOGSTATSD_SOCKET",
             default_value = "/var/run/datadog/dsd.socket"
         )]
         dsd_socket: PathBuf,

test/antithesis/harness/src/bin/eventually_adp_alive.rs

@@ -1,5 +1,4 @@
-//! Shared helpers for the Antithesis harness, used by the `src/bin/*` test
-//! commands.
+//! Shared helpers for Antithesis test commands.
 
 #[cfg(unix)]
 pub mod driver;

test/antithesis/harness/src/lib.rs

@@ -0,0 +1,18 @@
+[package]
+name = "antithesis-scenario-general"
+version = "0.1.0"
+edition = { workspace = true }
+license = { workspace = true }
+repository = { workspace = true }
+publish = false
+
+[lints]
+workspace = true
+
+[dependencies]
+antithesis_sdk = { workspace = true, features = ["full", "rand_v0_10"] }
+anyhow = { workspace = true, features = ["std"] }
+clap = { workspace = true, features = ["derive", "env", "error-context", "help", "std", "usage"] }
+harness = { path = "../../harness" }
+ryu = { workspace = true }
+serde_json = { workspace = true }

test/antithesis/scenarios/general/Cargo.toml

@@ -76,11 +76,11 @@ COPY . /tools
 RUN --mount=type=cache,target=/tools/target,id=antithesis-tools-target \
     --mount=type=cache,target=/root/.cargo/registry,id=cargo-registry \
     --mount=type=cache,target=/root/.cargo/git,id=cargo-git \
-    cargo build --release \
-        --bin antithesis-intake \
-        --bin parallel_driver_send_dogstatsd --bin parallel_driver_sketchburst \
-        --bin eventually_adp_alive \
-        --bin first_sample_config && \
+    cargo build --release --package antithesis-intake --bin antithesis-intake && \
+    cargo build --release --package harness \
+        --bin first_sample_config \
+        --bin eventually_adp_alive && \
+    cargo build --release --package antithesis-scenario-general --bins && \
     cp /tools/target/release/antithesis-intake /usr/local/bin/antithesis-intake && \
     cp /tools/target/release/parallel_driver_send_dogstatsd /usr/local/bin/parallel_driver_send_dogstatsd && \
     cp /tools/target/release/parallel_driver_sketchburst /usr/local/bin/parallel_driver_sketchburst && \
@@ -101,9 +101,9 @@ RUN mkdir -p /symbols && ln -s /usr/local/bin/agent-data-plane /symbols/agent-da
 # main.rs requires a config file at the default path. Ship a minimal standalone config as a
 # fallback. The boot wrapper overwrites it with the per-timeline config that first_sample_config
 # samples onto the shared `agent-config` volume.
-COPY test/antithesis/deploy/adp/datadog.yaml /etc/datadog-agent/datadog.yaml
+COPY test/antithesis/scenarios/general/adp/datadog.yaml /etc/datadog-agent/datadog.yaml
 # Boot wrapper waits for the config sentinel, copies the config into place, then execs ADP.
-COPY --chmod=755 test/antithesis/deploy/adp/entrypoint.sh /entrypoint.sh
+COPY --chmod=755 test/antithesis/scenarios/general/adp/entrypoint.sh /entrypoint.sh
 # ADP's control-plane secure API requires an IPC TLS cert (a single PEM holding both certificate and
 # private key) that the Core Agent normally generates. In standalone mode there is no Core Agent, so
 # generate a self-signed cert+key. An empty auth_token satisfies the IPC auth config at startup.
@@ -137,12 +137,12 @@ RUN test -d /usr/share/ca-certificates || ( \
     apt-get install --no-install-recommends -y ca-certificates && \
     rm -rf /var/lib/apt/lists/* )
 # Antithesis setup-complete helper and test templates (helper files + the "main" template dir).
-COPY --chmod=755 test/antithesis/deploy/workload/setup-complete.sh /opt/antithesis/setup-complete.sh
-COPY test/antithesis/deploy/workload/test/ /opt/antithesis/test/
+COPY --chmod=755 test/antithesis/scenarios/general/workload/setup-complete.sh /opt/antithesis/setup-complete.sh
+COPY test/antithesis/scenarios/general/workload/test/ /opt/antithesis/test/
 # Inject the compiled test-command binaries into the "main" test template.
 COPY --from=tools-builder --chmod=755 /usr/local/bin/first_sample_config /opt/antithesis/test/v1/main/first_sample_config
 COPY --from=tools-builder --chmod=755 /usr/local/bin/parallel_driver_send_dogstatsd /opt/antithesis/test/v1/main/parallel_driver_send_dogstatsd
 COPY --from=tools-builder --chmod=755 /usr/local/bin/parallel_driver_sketchburst /opt/antithesis/test/v1/main/parallel_driver_sketchburst
 COPY --from=tools-builder --chmod=755 /usr/local/bin/eventually_adp_alive /opt/antithesis/test/v1/main/eventually_adp_alive
-COPY --chmod=755 test/antithesis/deploy/workload/entrypoint.sh /entrypoint.sh
+COPY --chmod=755 test/antithesis/scenarios/general/workload/entrypoint.sh /entrypoint.sh
 ENTRYPOINT ["/entrypoint.sh"]