Repository navigation
chore: refresh store codegen snapshot #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JOY (JOY)
wants to merge
1
commit into
dev
Choose a base branch
from
automation/store-codegen-drift
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6,273 changes: 4,246 additions & 2,027 deletions
6,273
packages/store/scripts/api-schema/schema.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| e9984df7d8acc32efa5370bd62918903c1a9aedda334828d00ef55ff0e922556 | ||
| 8effdee12a6cc8346f753081903bb05abafee29d5cebb5dbcf63806561363e4c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 IMPORTANT: Breaking Type Contract Change for
proposedByFailure Trace:
proposedByinMessageandMessageItemfromAddressInfo(required, non-null) toAddressInfo | null(required, nullable).2. Existing client code (outside this diff) likely contains patterns like
message.proposedBy.addressormessage.proposedBy.namebased on the previous type definition.3. If the API now returns
nullforproposedBy(which is now a valid state per the new type), the client code will throw aTypeError: Cannot read properties of null (reading 'address')at runtime.4. Even if the API never returns
null, the type change forces all consumers to add null checks, indicating a semantic shift in the data contract that breaks existing type-safe code.Actionable Fix:
This is a generated file. The fix must be applied to the source of truth (the API schema or the code generator configuration) to ensure backward compatibility or to coordinate a breaking release. If this is an intentional breaking change, ensure all consumers are updated to handle
nullforproposedBy. If not, revert the schema change to keepproposedByasAddressInfo(non-nullable) or ensure the generator marks it as optionalAddressInfo | undefinedif the field can be absent, rather than nullableAddressInfo | nullif the field is always present but can be null.