Skip to content

chore: refresh store codegen snapshot - #8

Open
JOY (JOY) wants to merge 1 commit into
devfrom
automation/store-codegen-drift
Open

JOY (JOY) wants to merge 1 commit into
devfrom
automation/store-codegen-drift

Conversation

@JOY

@JOY JOY (JOY) commented Sep 8, 2026 •

Copy link
Copy Markdown
Collaborator

The Store Codegen Drift workflow detected an upstream schema change and regenerated the checked-in gateway client snapshot.

Changed generated files:

  • packages/store/scripts/api-schema/schema.json
  • packages/store/src/gateway/AUTO_GENERATED/.schema-hash
  • packages/store/src/gateway/AUTO_GENERATED/chains.ts
  • packages/store/src/gateway/AUTO_GENERATED/delegates.ts
  • packages/store/src/gateway/AUTO_GENERATED/messages.ts
  • packages/store/src/gateway/AUTO_GENERATED/relay.ts
  • packages/store/src/gateway/AUTO_GENERATED/spaces.ts
  • packages/store/src/gateway/AUTO_GENERATED/transactions.ts

This PR is automation-created, but it is intentionally not auto-merged.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the API schema by adding a nullable trialPeriodDays property of type number and updates the corresponding auto-generated schema hash file. There are no review comments, and I have no feedback to provide.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the API schema by adding a nullable trialPeriodDays property of type number to the schema definition. Additionally, the auto-generated schema hash file has been updated to reflect this change. There are no review comments, and I have no feedback to provide.

@coderabbitai

coderabbitai Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 542ccdfc-051c-4631-a983-4d34ad07fa6a

📥 Commits

Reviewing files that changed from the base of the PR and between 532efba and 6a09d97.

📒 Files selected for processing (2)
  • packages/store/scripts/api-schema/schema.json
  • packages/store/src/gateway/AUTO_GENERATED/.schema-hash
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/store/src/gateway/AUTO_GENERATED/.schema-hash

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The OpenAPI schema adds subscription update endpoints, token metadata endpoints, and supporting schemas. The PaymentLink schema adds nullable trialPeriodDays. The generated schema hash is updated.

Changes

API schema expansion

Layer / File(s) Summary
Subscription update contracts
packages/store/scripts/api-schema/schema.json
Adds preview and update subscription endpoints with request, response, and line-item schemas.
Token metadata contracts
packages/store/scripts/api-schema/schema.json
Adds single-token and multi-token metadata endpoints with native, ERC-20, and ERC-721 metadata schemas.
PaymentLink contract and schema hash
packages/store/scripts/api-schema/schema.json, packages/store/src/gateway/AUTO_GENERATED/.schema-hash
Adds nullable trialPeriodDays to PaymentLink and updates the stored schema hash.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: tmjssz

Merge Risk: ⚪ Minimal · up to 6a09d

The checked-in API schema and generated schema hash update do not show an actionable merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: refreshing the checked-in Store code generation snapshot after an upstream schema update.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch automation/store-codegen-drift

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JOY
JOY (JOY) force-pushed the automation/store-codegen-drift branch 7 times, most recently from e77d61f to aee8cd6 Compare September 15, 2026 06:18
@JOY
JOY (JOY) force-pushed the automation/store-codegen-drift branch 8 times, most recently from c6547d0 to 88a8fa2 Compare September 23, 2026 06:18
@JOY
JOY (JOY) force-pushed the automation/store-codegen-drift branch 4 times, most recently from 4eb35e4 to bf723a0 Compare September 27, 2026 06:18

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (6 files · 167,918 chars · 3 PR unit(s))

ℹ️ Full-Context Analysis: Analyzed all changed files in a unified context pass to preserve cross-file type definitions, imports, and caller contracts. Deducted 3 PR units.
⚠️ PR diff exceeded maximum review ceiling (3 batches / ~90,000 chars) - lower-priority files were skipped.

⏱️ Adversarial Review completed (Model: qwen3.8-27b)

🔍 Verified Adversarial Review Findings

📋 Findings Summary (1 inline finding)

  • 🟡 IMPORTANT packages/store/src/gateway/AUTO_GENERATED/messages.ts:124: Breaking Type Contract Change for proposedBy (Inline on diff)

🛡️ Dismissed Claims

  • logoUri, name, preparedSignature, origin changes: These fields changed from optional (?) to required nullable (: string | null). While this is a type change, it is generally safer for consumers than optional fields because it forces explicit handling of the null state rather than allowing undefined. Code that previously checked if (message.logoUri) will still work correctly (falsy for null). Code that accessed message.logoUri directly without a check would have been unsafe before (potentially undefined) and is now explicitly null, which is a more predictable failure mode. The primary risk is proposedBy becoming nullable, which is a more severe break for object property access.

name?: string | null
logoUri: string | null
name: string | null
message: string | TypedData

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 IMPORTANT: Breaking Type Contract Change for proposedBy

Failure Trace:

  1. The diff changes proposedBy in Message and MessageItem from AddressInfo (required, non-null) to AddressInfo | null (required, nullable).
    2. Existing client code (outside this diff) likely contains patterns like message.proposedBy.address or message.proposedBy.name based on the previous type definition.
    3. If the API now returns null for proposedBy (which is now a valid state per the new type), the client code will throw a TypeError: Cannot read properties of null (reading 'address') at runtime.
    4. Even if the API never returns null, the type change forces all consumers to add null checks, indicating a semantic shift in the data contract that breaks existing type-safe code.

Actionable Fix:
This is a generated file. The fix must be applied to the source of truth (the API schema or the code generator configuration) to ensure backward compatibility or to coordinate a breaking release. If this is an intentional breaking change, ensure all consumers are updated to handle null for proposedBy. If not, revert the schema change to keep proposedBy as AddressInfo (non-nullable) or ensure the generator marks it as optional AddressInfo | undefined if the field can be absent, rather than nullable AddressInfo | null if the field is always present but can be null.

@JOY
JOY (JOY) force-pushed the automation/store-codegen-drift branch 7 times, most recently from ed92ffc to 4b080e8 Compare October 4, 2026 08:04
@JOY
JOY (JOY) force-pushed the automation/store-codegen-drift branch 2 times, most recently from 8e6c78b to 4583026 Compare October 6, 2026 06:19

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (8 files · 429,365 chars · 3 PR unit(s))

ℹ️ Full-Context Analysis: Analyzed all changed files in a unified context pass to preserve cross-file type definitions, imports, and caller contracts. Deducted 3 PR units.
⚠️ PR diff exceeded maximum review ceiling (3 batches / ~90,000 chars) - lower-priority files were skipped.

⏱️ Adversarial Review completed (Model: qwen3.8-27b)

✅ CLEAN_PASS: Verified Clean by Adversarial Arbiter

🛡️ Dismissed Claims

  • packages/store/src/gateway/AUTO_GENERATED/messages.ts:110-155 (Message/MessageItem field optionality changes): The diff modifies files within the AUTO_GENERATED directory, which are machine-generated artifacts from an OpenAPI schema. The diff does not contain any hand-written client logic, UI components, or business logic that consumes these types. Therefore, there is no code in this diff that would throw a TypeError or exhibit broken UI logic due to these type changes. The "failure" described is a hypothetical consequence in downstream code not present in the provided diff.
  • packages/store/src/gateway/AUTO_GENERATED/transactions.ts:809-813 (SafeAppInfo type mismatch/duplication): The claim that SafeAppInfo is duplicated with "slightly different optional fields" is factually incorrect regarding the diff's impact. Both messages.ts and transactions.ts define SafeAppInfo with id: number and logoUri as nullable/optional respectively, but these are separate module-scoped types in generated code. There is no shared interface or import conflict introduced in this diff. Furthermore, the claim that "TypeScript compilation will pass... but runtime code accessing safeAppInfo.id will get undefined" is a speculative concern about backend data integrity, not a defect in the generated type definitions themselves. The generated types correctly reflect the updated schema (which now includes id). No concrete failure trace exists within the diff's scope.

CLEAN_PASS: The diff consists exclusively of auto-generated API client types and schema updates; no hand-written logic is modified, so the claimed runtime failures and type mismatches are unsupported by the provided code changes.

@JOY
JOY (JOY) force-pushed the automation/store-codegen-drift branch from 4583026 to 8e972a8 Compare October 7, 2026 06:17

@dos dos Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⏱️ Code Review completed (8 files · 429,365 chars · 3 PR unit(s))

ℹ️ Full-Context Analysis: Analyzed all changed files in a unified context pass to preserve cross-file type definitions, imports, and caller contracts. Deducted 3 PR units.
⚠️ PR diff exceeded maximum review ceiling (3 batches / ~90,000 chars) - lower-priority files were skipped.

✅ CLEAN_PASS: No candidate issues flagged

NO_ISSUES: The diff consists of auto-generated API client code and schema updates that are internally consistent and do not introduce functional defects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant