Repository navigation
ci: review this repository's own pull requests - #141
Merged
Merged
Conversation
general-pr-review.yaml skipped its job whenever the event was pull_request and the repository was ConductorOne/github-workflows. The organization ruleset that requires this workflow covers this repository too, and its injected run is also a pull_request event here, so the clause skipped that run as well: pull requests to this repository received no review, and the skipped job satisfied the ruleset. The clause was duplicate prevention from #82, where both review workflows briefly ran on this repository and raced on one summary comment. The connector workflow keeps its own self-skip, so removing this one yields a single review per pull request. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
gontzess
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Pull requests to this repository get no Claude review. The organization ruleset that requires
general-pr-review.yamlon managed repositories covers this repository too, and the injected run does start here, but the job'sif:skipped it: the condition wasgithub.event_name != 'pull_request' || github.repository != 'ConductorOne/github-workflows', and the injected run is apull_requestevent in this repository. A skipped required job counts as passing, so every PR here merged with the review check reporting "skipped" (see #140).What this changes
Deletes that
if:line. The event half of the condition only existed to exemptworkflow_callcallers from the self-skip, so once the repository check goes there is nothing left for it to do. Nothing else changes: fork PRs are still skipped by the same-repo guard on each step, and the connector workflowpr-review.yamlkeeps its own self-skip, so this repository gets exactly one review per PR instead of two racing on the same summary comment.Where the self-skip came from
Nobody recorded the reason, so here is the reconstruction from git and review history.
pull_request_target-triggered and lived in this repository, so it fired on this repository's own PRs. Its prompt opened with "You are reviewing a pull request for a ConductorOne connector repository", so the one repository that is not a connector excluded itself. No comment or PR text explains it; that is the inferred origin.general-pr-review.yamlwas created by copying the connector workflow and the clause came along verbatim, even though the connector-prompt reason no longer applied to the general profile.### General PR Review:heading and race to update one comment. The response came in two steps: "Guard PR review against stale heads" put the self-skip back on the connector workflow only, narrowed to nativepull_requestevents so reusable-workflow callers still run, and the reviewer's next summary records the intent that only the general workflow runs for this repository. Then "Skip general PR review self-runs" added the same clause to the general workflow, with no body and no thread. The managed-repository ruleset had been created a week earlier and already injected the general workflow here, so the likely trigger was a second duplicate: the injected run plus the native run of the same file. The clause chosen skips both, because the injected run is also apull_requestevent in this repository.So the clause's surviving purpose is duplicate prevention, and the last step overshot: it removed this repository's review entirely rather than only the redundant native run. On #140 only one general run existed, the injected one, so the duplicate from May does not reproduce today.
Rollout
The injected run always executes the workflow from
main, so this PR is still reviewed by the old condition and reports skipped. The first review lands on the next PR after this merges. The injected run checks out the workflow repository through contexts that the required-workflow machinery fills in; on a managed repository they resolve to this repository atmain, and the same is expected here, but the self-repository case cannot be exercised before merge. If it did fail, the next PR's required check fails loudly and the revert is this one line.Validation
actionlinton the changed file: the only findings are the pre-existingjob.workflow_repository/job.workflow_shaexpressions, unchanged by this PR.git diff --checkclean.🤖 Generated with Claude Code