Skip to content

docs: note that this repository's own pull requests are reviewed - #142

Closed
jugonzalez12 wants to merge 1 commit into
mainfrom
jugonzalez/review-smoke-test
Closed

jugonzalez12 wants to merge 1 commit into
mainfrom
jugonzalez/review-smoke-test

Conversation

@jugonzalez12

Copy link
Copy Markdown
Contributor

Follows #141, which removed the self-skip from the general review workflow. This is also the first pull request after that merge, so it exercises the injected review run on this repository.

Follows #141, which removed the self-skip from the general review
workflow. This is also the first pull request after that merge, so it
exercises the injected review run on this repository.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Superseded — see the current review report for commit e6897fbfe62e

General PR Review: docs: note that this repository's own pull requests are reviewed

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: none loaded - .claude/skills/ci-review.md was not found at trusted base cafb63b7c23c.
Review mode: full
View review run

Review Summary

This PR changes only README.md. It adds one sentence saying pull requests to this repository are now reviewed, using the workflow and action on main rather than the versions the pull request proposes. I scanned the full diff for security and correctness and checked the claim against the code and this PR's runs. The general-pr-review.yaml run for this PR has workflow_ref @refs/heads/main, and it checks out the action at job.workflow_sha (general-pr-review.yaml:31-40), so the claim holds for the general workflow. No repo-local criteria loaded, so only the base criteria were applied.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • New (confidence: medium) README.md:9-11: the new sentence sits in the section about the default connector profile and doesn't say which workflow reviews this repository. pr-review.yaml:24 still skips ConductorOne/github-workflows on pull_request, and that job's run on this PR was skipped. Only general-pr-review.yaml reviews this repository.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 9-11: The sentence "Pull requests to this repository are reviewed as well..." sits in the section about the default connector profile, but `.github/workflows/pr-review.yaml` line 24 still skips this repository on `pull_request` events. Only `general-pr-review.yaml` reviews it. Reword the sentence to name `general-pr-review.yaml`, for example: "Pull requests to this repository are reviewed by the `general-pr-review.yaml` workflow and action on `main` rather than the version a pull request proposes." Also reflow the paragraph so the short line "version a pull request proposes. The action builds its" merges with the next line.

Comment thread README.md
Comment on lines +9 to +11
head SHA so Claude can inspect the proposed source tree locally. Pull requests to this
repository are reviewed as well, by the workflow and action on `main` rather than the
version a pull request proposes. The action builds its

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion (confidence: medium): This sentence is in the section about the default connector profile, but only general-pr-review.yaml reviews this repository. pr-review.yaml:24 still skips ConductorOne/github-workflows on pull_request, and its run on this PR was skipped. Consider naming general-pr-review.yaml here, e.g. "Pull requests to this repository are reviewed by the general-pr-review.yaml workflow and action on main…".

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

General PR Review: docs: note that this repository's own pull requests are reviewed

Blocking Issues: 0 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: none loaded - .claude/skills/ci-review.md was not found at trusted base cafb63b7c23c.
Review mode: full
View review run

Review Summary

This PR changes only README.md. It adds one sentence saying pull requests to this repository are now reviewed, using the workflow and action on main rather than the versions the pull request proposes. I scanned the full diff for security and correctness and checked the claim against the code and this PR's runs. The general-pr-review.yaml run for this PR has workflow_ref @refs/heads/main, and it checks out the action at job.workflow_sha (general-pr-review.yaml:31-40), so the claim holds for the general workflow. No repo-local criteria loaded, so only the base criteria were applied.

Security Issues

None found.

Correctness Issues

None found.

Suggestions

  • New (confidence: medium) README.md:9-11: the new sentence sits in the section about the default connector profile and doesn't say which workflow reviews this repository. pr-review.yaml:24 still skips ConductorOne/github-workflows on pull_request, and that job's run on this PR was skipped. Only general-pr-review.yaml reviews this repository.
Prompt for AI agents
Verify each finding against the current code and only fix it if needed.

## Suggestions

In `README.md`:
- Around line 9-11: The sentence "Pull requests to this repository are reviewed as well..." sits in the section about the default connector profile, but `.github/workflows/pr-review.yaml` line 24 still skips this repository on `pull_request` events. Only `general-pr-review.yaml` reviews it. Reword the sentence to name `general-pr-review.yaml`, for example: "Pull requests to this repository are reviewed by the `general-pr-review.yaml` workflow and action on `main` rather than the version a pull request proposes." Also reflow the paragraph so the short line "version a pull request proposes. The action builds its" merges with the next line.

Reviewed commit: e6897fbfe62e

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blocking issues found — see the full review report

@jugonzalez12

Copy link
Copy Markdown
Contributor Author

closing this, this was just a test to get the PR review to pop up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant