Skip to content

Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 3 | Quote-generator-app #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jacknguyen4438 wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −1
Open

Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 3 | Quote-generator-app #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba9667d
Changing the title of HTML
Jacknguyen4438 Apr 21, 2026
8eb4652
Writing the function that change to random quote with their author
Jacknguyen4438 Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sprint-3/quote-generator/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Title here</title>
<title>Quote generator app</title>
<script defer src="quotes.js"></script>
</head>
<body>
Expand Down
15 changes: 15 additions & 0 deletions Sprint-3/quote-generator/quotes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,3 +491,18 @@ const quotes = [
];

// call pickFromArray with the quotes array to check you get a random quote

function showRandomQuote() {
const randomQuote = pickFromArray(quotes);

const quoteP = document.querySelector("#quote");
const authorP = document.querySelector("#author");

quoteP.innerText = randomQuote.quote;
authorP.innerText = randomQuote.author;
}

showRandomQuote();

const newQuoteBtn = document.querySelector("#new-quote");
newQuoteBtn.addEventListener("click", showRandomQuote);
Comment on lines +505 to +508
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider placing all the "run on load" code inside a function to make it clearer that
"this is what runs when the page loads." For examples,

function setup() {
  // code to be executed on page load
}

window.addEventListener('load', setup);

or

window.addEventListener('load', function() {
  // code to be executed on page load
});

Copy link
Copy Markdown
Author

@Jacknguyen4438 Jacknguyen4438 May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feed back I will post the answer here when I am done thank you.

Loading