Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 3 | Quote-generator-app#1218
Open
Jacknguyen4438 wants to merge 2 commits into
Open
Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 3 | Quote-generator-app#1218Jacknguyen4438 wants to merge 2 commits into
Jacknguyen4438 wants to merge 2 commits into
Conversation
Jacknguyen4438
added
📅 Sprint 3
cjyuan
reviewed
May 10, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
To provide fuller context for this code review, can you include the link to your previous reviewed PR in the PR description?
cjyuan
added
Reviewed
Author
|
Hello @cjyuan and Thank you for the feedback I have change the description to help it explain more on what is this PR is about. if any further change need to be make please let me know. |
cjyuan
reviewed
May 10, 2026
Comment on lines
+505
to
+508
| showRandomQuote(); | ||
|
|
||
| const newQuoteBtn = document.querySelector("#new-quote"); | ||
| newQuoteBtn.addEventListener("click", showRandomQuote); |
Contributor
There was a problem hiding this comment.
Could consider placing all the "run on load" code inside a function to make it clearer that
"this is what runs when the page loads." For examples,
function setup() {
// code to be executed on page load
}
window.addEventListener('load', setup);or
window.addEventListener('load', function() {
// code to be executed on page load
});
Author
There was a problem hiding this comment.
Thank you for the feed back I will post the answer here when I am done thank you.
cjyuan
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Hello thank you for checking this PR. I have done this course work beforehand and here is the old PR link from ITP-JAN for this course work and it ready to be check again Quote-generator-app #1210.. This is the same with my PR for this module so if additional change need to be add please let me know
Questions
No Question.