Skip to content

fix: unsafe transformer disable system property #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derklaro merged 2 commits into from
Jul 3, 2025
Merged

fix: unsafe transformer disable system property #1681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d3bddd
fix: unsafe transformer disable system property
Jul 2, 2025
404afb6
better variable name
Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions wrapper-jvm/impl/src/main/java/eu/cloudnetservice/wrapper/impl/Premain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,11 @@ public static void premain(@Nullable String agentArgs, @NonNull Instrumentation
// init and registers the unsafe transformer very early in the process. this is done here
// as we usually don't allow transformers to be registered so early as they're intended to
// transform classes brought in by the wrapped application, not by the jdk
UnsafeTransformer.init(inst);
Premain.transformerRegistry.registerTransformer(new UnsafeTransformer());
var unsafeTransformerDisabled = Boolean.getBoolean("cloudnet.wrapper.unsafe-transform-disabled");
if (!unsafeTransformerDisabled) {
UnsafeTransformer.init(inst);
Premain.transformerRegistry.registerTransformer(new UnsafeTransformer());
}
}

public static void preloadClasses(@NonNull Path file, @NonNull ClassLoader loader) {
Expand Down
6 changes: 1 addition & 5 deletions ...mpl/src/main/java/eu/cloudnetservice/wrapper/impl/transform/unsafe/UnsafeTransformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,9 @@ public final class UnsafeTransformer implements ClassTransformer {
MethodTypeDesc.of(ConstantDescs.CD_void, ConstantDescs.CD_String, ConstantDescs.CD_String);

/**
* Constructs a new instance of this transformer, usually done via SPI.
* Constructs a new instance of this transformer, only public for internal use.
*/
public UnsafeTransformer() {
var transformerDisabled = Boolean.getBoolean("cloudnet.wrapper.unsafe-transform-disabled");
if (transformerDisabled) {
throw new UnsupportedOperationException("transformer disabled via system property");
}
}

/**
Expand Down
Loading