fix: unsafe transformer disable system property#1681
Merged
Conversation
derklaro
added
p: high
Test Results 56 files ±0 56 suites ±0 2m 59s ⏱️ +5s Results for commit 404afb6. ± Comparison against base commit c357ab8. This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both. |
0utplay
approved these changes
Jul 3, 2025
derklaro
added a commit
that referenced
this pull request
Jul 3, 2025
### Motivation The unsafe transformer is registered in a different way than usual (usually transformers are registered via SPI), so disabling the transformer by throwing an exception is not a viable option as it results in a jvm crash. ### Modification Move the transformer disabled check into the premain class and don't try to construct/register the transformer if it is disabled. ### Result No more jvm crashes when the unsafe transformer is disabled using a system property. (cherry picked from commit ce44537)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The unsafe transformer is registered in a different way than usual (usually transformers are registered via SPI), so disabling the transformer by throwing an exception is not a viable option as it results in a jvm crash.
Modification
Move the transformer disabled check into the premain class and don't try to construct/register the transformer if it is disabled.
Result
No more jvm crashes when the unsafe transformer is disabled using a system property.