Skip to content

Fix implicit usage paths#977

Merged
vincent-botbol merged 3 commits into
masterfrom
fix-implicit-usage-paths
Mar 5, 2026
Merged

Fix implicit usage paths#977
vincent-botbol merged 3 commits into
masterfrom
fix-implicit-usage-paths

Conversation

@vincent-botbol

@vincent-botbol vincent-botbol commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

Fix implicitly open types path resolution & hash discrepancy

Sister PR: CatalaLang/catala-examples#40

AltGr added 2 commits March 3, 2026 15:12
- When hashing, only the last path element needs to be hashed (module names are unambiguous, but the same module can be accessed through multiple dependency paths
- Anyway, for type names, we strip the path in the same way: that seems cleaner e.g. in error messages. But the 1st point is enough to fix the bug
@vincent-botbol vincent-botbol requested a review from AltGr March 3, 2026 14:13

@AltGr AltGr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vincent-botbol vincent-botbol merged commit d332936 into master Mar 5, 2026
19 of 24 checks passed
@vincent-botbol vincent-botbol deleted the fix-implicit-usage-paths branch March 5, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants