Fix period and optionals in testcase editor#207
Merged
Conversation
rprimet
approved these changes
Mar 5, 2026
rprimet
left a comment
rprimet
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! I tested it manually and it works, I suggest two changes (I pushed the corresponding commits, feel free to discard)
|
|
||
| let unsupported fmt = Format.ksprintf (fun msg -> raise (Unsupported msg)) fmt | ||
|
|
||
| let implicit_stdlib_alias, lookup_aliased_name = |
Collaborator
There was a problem hiding this comment.
it seems that implicit_stdlib_alias is unused, I took the liberty of removing it (don't hesitate to drop my extra commits if not relevant/bad)
| in | ||
| let fr_names = | ||
| ["Date"; "MoisAnnée"; "Période"; "Argent"; "Entier"; "Décimal"; "Liste"] | ||
| @ List.map (fun s -> s ^ "_fr") en_names |
Collaborator
There was a problem hiding this comment.
This will produce unneeded module names like Period_en_fr
Collaborator
Author
There was a problem hiding this comment.
Well spotted.
vincent-botbol
force-pushed
the
fix-period-and-optionals
branch
from
8612fb9 to
9f9bc28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the testcase output of stdlib's implicit structures (such as Period) and their types.
It also add support for optional values.
Depends on CatalaLang/catala#977