Skip to content

refactor(avatars): move Avatars, Profile Banner and Part Library bridge methods into its feature folder (H-2 step 4) - #4798

Open
DoodleBears wants to merge 1 commit into
mainfrom
codex/4521-feature-4-avatars
Open

DoodleBears wants to merge 1 commit into
mainfrom
codex/4521-feature-4-avatars

Conversation

@DoodleBears

@DoodleBears DoodleBears commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Issue #4521 | Feature map | Agent claim

Refs #4521 · Task codex/local/01a1facb-cf39-7073-b834-099ba7ac4e4d

Why the change

Extract the bridge code for Avatars, Profile Banner and Part Library so the Host and Client composition files can delegate to the feature modules.

Special things to note

  • Merge risk: two-way door (revert this refactor), medium blast radius for PersonaBot Profile appearance and Part Library editing. Stacks on refactor(skills): move Skills bridge methods into its feature folder (H-2 step 3) #4795. Review the Bot DM scope, Part Library import and export references, and the calls into the existing PersonaBot Registry.
  • Verification: Typecheck, lint, and the build passed. 286 tests passed across seven selected files with two workers. The source comparison matched the Host and Client handler bodies, Typert adapters, and registration order. Browser and Computer bundles matched the base. The slice checks ran before replaying onto current main. After the replay, the source comparison passed again and typecheck, lint, and build passed on the stack tip.
  • The Client aggregate still owns the existing Part Library validator import and passes it to the feature bridge.

Change outline

Host bridge → features/avatars/rpc.ts → features/avatars/methods.ts
Client bridge → features/avatars/bridge.ts → existing Host calls

Moved methods: botAvatarSet, botBannerSet, botAppearanceSet, botPrimaryColorSet, partLibraryList, partLibraryAdd, partLibraryExport, partLibraryImport, partLibraryImportImage.

@DoodleBears DoodleBears added harness:codex model:gpt-6.2-sol Code authored by GPT-6.2 Sol labels Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 2 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 4f1a084 and 21ddee4.

Files selected for processing: 7

  • packages/client/src/client/bridge.ts
  • packages/client/src/client/features/avatars/bridge.ts
  • packages/core/src/bridge/methods.ts
  • packages/core/src/bridge/rpc.ts
  • packages/core/src/features/avatars/methods.ts
  • packages/core/src/features/avatars/rpc.ts
  • scripts/client-host-import-baseline.json
Pre-merge checks: Passed 4

Check name Status Explanation
Fix Targets The Root Cause Passed The check applies only when the PR title starts with "fix". The provider-reported title is "refactor(avatars): move Avatars, Profile Banner and Part Library bridge methods into its feature folder (H-2…
Consistent With Adrs And Existing Features Passed The check applies: the PR changes code. The change is a behaviour-preserving move, not a new feature. Evidence: 1. ADR conflicts: docs/adr/ has ADR-0353 through ADR-0359. Only ADR-0358 (Apply Count) a…
Product Terms Follow The Glossary Passed The check covers user-visible copy, docs, and the PR description added by the diff, and fails only when a product noun is used in a GLOSSARY.md sense with a word listed under Avoid. **PR description…
Touched Features Are Verified Passed The check passes because no verification feature is mapped to the files this PR changes. Scope: PR #4798 (BotHarness/DeepSeekBot, author DoodleBears, base codex/4521-feature-3-skills) adds one commit,…
Full details: Fix Targets The Root Cause

Explanation

The check applies only when the PR title starts with "fix". The provider-reported title is "refactor(avatars): move Avatars, Profile Banner and Part Library bridge methods into its feature folder (H-2 step 4)". It starts with "refactor", not "fix". The check is therefore inapplicable, and it passes by its own terms. I did not inspect the diff, because the applicability condition is decided by the title alone.

Full details: Consistent With Adrs And Existing Features

Explanation

The check applies: the PR changes code. The change is a behaviour-preserving move, not a new feature. Evidence: 1. ADR conflicts: docs/adr/ has ADR-0353 through ADR-0359. Only ADR-0358 (Apply Count) and ADR-0359 (Marketplace Avatar image processing on the client) mention avatars. Neither covers the moved code. The moved methods are botAvatarSet, botBannerSet, botAppearanceSet, botPrimaryColorSet and the partLibrary* methods. None of them touch Apply Count, marketplace upload, or image validation rules. No accepted ADR is contradicted, so no ADR update is needed. 2. No second implementation: the commit (25d90e6) removes the handlers from packages/core/src/bridge/methods.ts. A grep finds no remaining definitions of the moved methods there. The same handlers now live in packages/core/src/features/avatars/methods.ts (createAvatarsBridgeMethods). methods.ts calls it at line 3039. Bridge wiring goes through features/avatars/rpc.ts. The client bridge.ts also delegates to features/avatars/bridge.ts, and its avatar-appearance import count drops from 2 to 1 in the baseline file. This matches the earlier skills and schedules extractions, which follow the same features/<name>/ layout. Residual note: I did not run typecheck or tests. The sandbox has no toolchain. The verdict rests on diff and structure evidence, not runtime behaviour.

Full details: Product Terms Follow The Glossary

Explanation

The check covers user-visible copy, docs, and the PR description added by the diff, and fails only when a product noun is used in a GLOSSARY.md sense with a word listed under Avoid. PR description (provided text): The phrase reads "medium blast radius for PersonaBot Profile appearance and Part Library editing". The glossary's PersonaBot entry lists "bot (bare)" under Avoid, and the Avatar Species entry lists "Family" under Avoid. The description uses "Bot DM" and "Bot-to-Bot DM", which are not avoided forms. "Profile Banner", "Part Library", "Avatars", "Host", "Client bridge", and "PersonaBot Registry" are glossary terms or are not avoided words. "agent claim" refers to a task claim on an issue, not a PersonaBot, so the Agent entry does not apply. No bare "Profile" appears in the current description. Added code (commit 25d90e6): The commit moves handler code into features/avatars/ and adds no docs, locale strings, or new UI copy. The only added text is code identifiers and error strings such as invalid botBannerSet response. These contain no Avoid words used in a glossary sense. The commit touches no .md files. Prior failure: The standing FAIL cites a bare "Profile appearance" in the PR description. The current description already says "PersonaBot Profile appearance", which matches the required resolution. The prior claim does not match the current description text. No Avoid misuse was found, so the check passes. Prior failure refuted: The prior FAIL said the PR description uses bare "Profile" in "medium blast radius for Profile appearance". The current provider-reported PR description reads "medium blast radius for PersonaBot Profile appearance and Part Library editing", which is the preferred term. The only other "Profile" is the defined term "Profile Banner". The added code commit 25d90e6 adds no docs or UI copy with avo...

Full details: Touched Features Are Verified

Explanation

The check passes because no verification feature is mapped to the files this PR changes. Scope: PR #4798 (BotHarness/DeepSeekBot, author DoodleBears, base codex/4521-feature-3-skills) adds one commit, 25d90e6, on top of cc89342. That commit changes 7 files: - packages/client/src/client/bridge.ts - packages/client/src/client/features/avatars/bridge.ts - packages/core/src/bridge/methods.ts - packages/core/src/bridge/rpc.ts - packages/core/src/features/avatars/methods.ts - packages/core/src/features/avatars/rpc.ts - scripts/client-host-import-baseline.json Mapping: I read the ## Sources globs of all 85 feature files in .agents/skills/verify-deepseekbot/features/ and expanded their brace patterns. I matched them against the 7 changed paths. The result was zero matches. The closest candidates did not match either: - local-appearance.md covers packages/client/src/client/appearance*. - marketplace.md covers market-avatars.tsx. - phone-channel-avatars.md covers apps/mobile paths. - personabot-create.md covers persona-bot-create.tsx. No feature file covers packages/core/src/bridge/** or packages/core/src/features/avatars/**. Stack context: the diff against main contains 70 feature hits. Those come from earlier commits in the stacked branch, not from this PR's own commit. The PR targets the feature-3-skills branch, and this commit is the only change on top of cc89342. The base branch is not present locally, so the tip is inferred from commit order. Even so, the mapping of the PR's own commit is empty. Result: no mapped feature is touched, so the check passes. The PR body's verification notes are not evaluated because the check does not apply.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the needs-human A human maintainer must decide whether to merge this PR label Nov 20, 2026
@github-actions

Copy link
Copy Markdown

Human merge required (needs-human)

  • Installed-client protocol contracts
    • packages/core/src/bridge/methods.ts
    • packages/core/src/bridge/rpc.ts

Merge policy

…tep 4)

Refs #4521

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DoodleBears
DoodleBears force-pushed the codex/4521-feature-4-avatars branch from 926b100 to 21ddee4 Compare November 20, 2026 23:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harness:codex model:gpt-6.2-sol Code authored by GPT-6.2 Sol needs-human A human maintainer must decide whether to merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant