Skip to content

refactor(genui): move GenUI private views bridge methods into its feature folder (H-2 step 5) - #4800

Open
DoodleBears wants to merge 1 commit into
codex/4521-feature-4-avatarsfrom
codex/4521-feature-5-genui
Open

DoodleBears wants to merge 1 commit into
codex/4521-feature-4-avatarsfrom
codex/4521-feature-5-genui

Conversation

@DoodleBears

Copy link
Copy Markdown
Contributor

Issue #4521 | Feature map | Agent claim

Refs #4521 · Task codex/local/01a1facb-cf39-7073-b834-099ba7ac4e4d

Why the change

Extract the bridge code for GenUI private views so the Host and Client composition files can delegate to the feature modules.

Special things to note

  • Merge risk: two-way door (revert this refactor), medium blast radius for private report and document view state. Stacks on refactor(avatars): move Avatars, Profile Banner and Part Library bridge methods into its feature folder (H-2 step 4) #4798. Review trusted Human scoping, document validation, and expected-version forwarding.
  • Verification: Typecheck, lint, and the declaration build passed on the rebased stack. All 104 tests across three selected files passed with two workers. The source comparison matched the Host handler bodies, Typert adapter bodies, and registration order. Browser and Computer bundles matched the base.
  • The Client aggregate passes its existing report schema to the feature bridge, retaining the path-scoped import.

Change outline

Host bridge → features/genui/rpc.ts → features/genui/methods.ts
Client bridge → features/genui/bridge.ts → existing Host calls

Moved methods: channelGenuiView, channelGenuiViewSave.

@DoodleBears DoodleBears added harness:codex model:gpt-6.2-sol Code authored by GPT-6.2 Sol labels Nov 20, 2026
@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions github-actions Bot added the needs-human A human maintainer must decide whether to merge this PR label Nov 20, 2026
@github-actions

Copy link
Copy Markdown

Human merge required (needs-human)

  • Installed-client protocol contracts
    • packages/core/src/bridge/methods.ts
    • packages/core/src/bridge/rpc.ts

Merge policy

@DoodleBears
DoodleBears force-pushed the codex/4521-feature-4-avatars branch from 25d90e6 to f82a90f Compare November 20, 2026 22:58
@DoodleBears
DoodleBears force-pushed the codex/4521-feature-5-genui branch from 14a0aea to 9f5e32c Compare November 20, 2026 22:58
@DoodleBears
DoodleBears force-pushed the codex/4521-feature-4-avatars branch from f82a90f to 926b100 Compare November 20, 2026 23:18
@DoodleBears
DoodleBears force-pushed the codex/4521-feature-5-genui branch from 9f5e32c to b8a6fa0 Compare November 20, 2026 23:19
@DoodleBears
DoodleBears force-pushed the codex/4521-feature-4-avatars branch from 926b100 to 21ddee4 Compare November 20, 2026 23:38
…ep 5)

Refs #4521

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@DoodleBears
DoodleBears force-pushed the codex/4521-feature-5-genui branch from b8a6fa0 to 30949c0 Compare November 20, 2026 23:38

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harness:codex model:gpt-6.2-sol Code authored by GPT-6.2 Sol needs-human A human maintainer must decide whether to merge this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant