Repository navigation
fix(print): drop the flip counts from the printed inclusion tables; close the verdicts print with the robust count - #223
Merged
Conversation
…clusion table print.summary.bgms() and print.summary.bgmCompare() print the inclusion table without the n0->1 and n1->0 columns. The columns stay in summary(fit)$indicator and every extractor. Snapshot and NEWS follow.
…e near-threshold count print.bgms_verdicts() prints, for the indicators that carry a verdict, how many lie far enough from an evidence threshold that Monte Carlo error does not move them, then how many lie within two standard errors of one with the remedy of a longer run; with none flagged the line says so. This replaces the "Monte-Carlo fragile" warning that appeared only when some verdict was flagged. The fragile column and the returned object are unchanged; its documentation names it the near-threshold flag. Snapshot, tests and NEWS follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two print-only changes on top of #222. The summary objects and the verdicts data frame are unchanged.
Printed inclusion tables (
print.summary.bgms,print.summary.bgmCompare)The directional flip counts
n0->1andn1->0are no longer printed. They remain insummary(fit)$indicatorandsummary(fit)$main_difference_selection/$pairwise_difference_selection, so anyone who uses them can still read them from the object. The printed columns are now the Rao-Blackwellized inclusion estimate with its Monte Carlo standard error, standard deviation, effective sample size and R-hat, plus the one-sentence note from #222 on blank cells.Verdicts print (
print.bgms_verdicts)The closing line of the printed table states the robust count first and the near-threshold count second:
When no verdict is near a threshold the second sentence is "None lies within two standard errors of one." The
fragilecolumn is unchanged; its documentation calls it the near-threshold flag.Verification
tests/testthat/test-methods.R,test-verdicts.R,test-summary-marking.R,test-bgmCompare.R,test-extractors.R,test-prior-sensitivity.Rpass; snapshots for the verdicts and summary-marking prints updated.R CMD check --as-cran: 0 errors, 0 warnings, 1 note (the incoming-feasibility URL check returned a 504 for the GitHub repository URL during the run).dev/review-2026-08/repro/printed-demos.Randprinted-compare.R(run byrun-printed.sh), output in~/bgms-review/printed-comparison.txt. It shows the flip columns gone from the print and present in the object, and the new closing lines ofverdicts().Note
The flip counts appear in the current tutorial's printed output. The tutorial text has not been updated; that is a separate discussion.