Repository navigation
fix(summary): drop share_incl and the indicator transition counts from the summary tables; make extract_ess(estimator = "mixt") defunct - #224
Merged
Conversation
…m the summary tables; make extract_ess(estimator = "mixt") defunct The pairwise table of a bgm() fit and the difference tables of a bgmCompare() fit lose the share_incl column. The inclusion tables and the stochastic-block co-clustering table lose the directional transition counts n0->1 and n1->0; the co-clustering table also loses n0->0, n1->1 and the transition-based n_eff_mixt. The tables hold mean, mcse, sd, n_eff and Rhat. extract_ess() keeps its estimator argument; "mixt", deprecated in 0.2.0.0, now errors through lifecycle::deprecate_stop(). The transition ESS is no longer recomputed from the raw indicator draws. The diagnostics vignette no longer describes the transition counts, and the roxygen for extract_ess(), extract_rhat() and extract_posterior_inclusion_probabilities() drops the transition estimator.
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three removals from the summary tables and one lifecycle step. Follows #223, which took the transition counts out of the printed inclusion table only.
Summary tables
bgm()fit and the difference tables of abgmCompare()fit lose theshare_inclcolumn, the inclusion part's fraction of the composite Monte Carlo variance of a weight. Nothing in the package read it;n_eff, the composite effective sample size it was computed beside, is unchanged.n0->1andn1->0, from the summary object as well as the print.summary(fit)$allocations) losesn0->0,n0->1,n1->0,n1->1and the transition-basedn_eff_mixt. The counts entered this table and the inclusion table in the same commit (2025-08-01).Every table now holds
mean,mcse,sd,n_eff(where defined) andRhat. The one-sentence note from #222 on blank cells is unchanged.extract_ess()
extract_ess(estimator = "mixt"), deprecated with a warning in 0.2.0.0, is defunct: the call stops throughlifecycle::deprecate_stop()with a message naming the change andestimator = "rb". The argument stays in the signature for this release so the error is the lifecycle one; removing the argument is a later step. The transition ESS is no longer recomputed from the raw indicator draws, so the helper that did so is gone. Fits saved by bgms < 0.2.0.0 previously fell back to the transition ESS silently; theirindicatorelement now errors with the same messageextract_posterior_inclusion_probabilities()gives.No external caller passes
estimator: easybgm, the tutorial project and the budget scripts all callextract_ess(fit).Documentation
The diagnostics vignette no longer describes the transition counts (the R-hat paragraph and one bullet). The roxygen for
extract_ess(),extract_rhat()andextract_posterior_inclusion_probabilities()drops the transition estimator and the counts. NEWS: two bullets under Diagnostics, one under Deprecations.Not changed
The C++ kernel
.compute_indicator_ess_cppstill returns the four transition counts andn_eff_mixt; only its own unit tests read them now.Verification
tests/testthat/test-rb-inclusion-probabilities.R58,test-mcmc-diagnostics.R171,test-extractor-functions.R691,test-methods.R1912,test-bgmCompare.R96,test-summary-marking.R38,test-regressions-2.R34,test-sample-sbm-prior.R13,test-sbm-correction.R36; all pass. Snapshotsummary-marking.mdupdated for the pairwise table.R CMD check --as-cran: 0 errors, 0 warnings, 0 notes.dev/review-2026-08/repro/dropcols-demos.Randdropcols-compare.R(run byrun-dropcols.sh), output in~/bgms-review/dropcols-comparison.txt. It shows the column sets of every table before and after, the printed header rows, and the warning-to-error change ofextract_ess(fit, estimator = "mixt")with both messages.