Some CMake maintenance#132
Conversation
|
Superceeded by #136 |
|
Sorry I failed to look closely. Would you please rebase to resolve the conflicts and I'll take a better look. |
32e36d5 to
3b869ad
Compare
Here you go. I did not look carefully into |
| # Vladimir S. FONOV - vladimir.fonov@gmail.com | ||
|
|
||
| cmake_minimum_required(VERSION 3.10) | ||
| cmake_minimum_required(VERSION 3.10...4.2) |
There was a problem hiding this comment.
Did you test all the up to 4.2?
There was a problem hiding this comment.
Hoping primarily that the CI can pick up on any issues. This can easily be added with https://github.com/jwlawson/actions-setup-cmake if you are interested.
Overall though the thing that this one does is set the policies to new, and if something on the list does not catch the attention, it should mostly be fine (preferably if the CI checks it as well)
|
Would you pleas rebase one more time on master, we updated our build workflows. Thanks! |
3b869ad to
fdf1845
Compare
|
Thanks for the followup, it passes the current CI and I'll look at the cmake actions one you suggested. |
cmake_minimum_requiredhas to be beforeprojectGNUInstallDirsdefaults,LIB_SUFFIXwas never a standardized variable