Skip to content

Commit 3508a98

Browse files
authored
Merge pull request #132 from LecrisUT/cmake/maintenance
2 parents 771909d + fdf1845 commit 3508a98

3 files changed

Lines changed: 15 additions & 13 deletions

File tree

CMakeLists.txt

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# Andrew Janke - a.janke@gmail.com
44
# Vladimir S. FONOV - vladimir.fonov@gmail.com
55

6-
cmake_minimum_required(VERSION 3.10)
6+
cmake_minimum_required(VERSION 3.10...4.2)
77

88
project(LIBMINC)
99

@@ -24,9 +24,7 @@ include(CTest)
2424

2525
enable_testing()
2626

27-
if( POLICY CMP0063 )
28-
cmake_policy(SET CMP0063 NEW)
29-
endif()
27+
include(GNUInstallDirs)
3028

3129
if(MINC_TOOLKIT_BUILD)
3230
set(LIBMINC_EXTERNALLY_CONFIGURED ON)
@@ -56,11 +54,15 @@ if(NOT LIBMINC_EXTERNALLY_CONFIGURED)
5654

5755
option(LIBMINC_USE_ASAN "Build with Address Sanitizer" OFF)
5856

57+
if(DEFINED LIB_SUFFIX)
58+
message(WARNING "LIB_SUFFIX is deprecated, use the standard CMAKE_INSTALL_LIBDIR instead")
59+
endif()
60+
5961
set (LIBMINC_EXPORTED_TARGETS "LIBMINC-targets")
60-
set (LIBMINC_INSTALL_BIN_DIR bin)
61-
set (LIBMINC_INSTALL_LIB_DIR lib${LIB_SUFFIX})
62-
set (LIBMINC_INSTALL_INCLUDE_DIR include)
63-
set (LIBMINC_INSTALL_DATA_DIR share)
62+
set (LIBMINC_INSTALL_BIN_DIR ${CMAKE_INSTALL_BINDIR})
63+
set (LIBMINC_INSTALL_LIB_DIR ${CMAKE_INSTALL_LIBDIR})
64+
set (LIBMINC_INSTALL_INCLUDE_DIR ${CMAKE_INSTALL_INCLUDEDIR})
65+
set (LIBMINC_INSTALL_DATA_DIR ${CMAKE_INSTALL_DATADIR})
6466

6567
if(LIBMINC_MINC1_SUPPORT)
6668
find_package(NETCDF REQUIRED)
@@ -450,7 +452,7 @@ endif()
450452

451453
# Keep this variable for compatibility
452454
set(VOLUME_IO_LIBRARY minc2)
453-
set(CMAKE_INSTALL_RPATH ${CMAKE_INSTALL_PREFIX}/lib${LIB_SUFFIX})
455+
set(CMAKE_INSTALL_RPATH ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR})
454456

455457
add_library(${LIBMINC_LIBRARY} ${LIBRARY_TYPE} ${minc_LIB_SRCS} ${minc_HEADERS} ${volume_io_LIB_SRCS} ${volume_io_HEADERS} )
456458

cmake-modules/BuildNIFTI.cmake

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ macro(build_nifti install_prefix staging_prefix)
7575
-DCMAKE_SKIP_RPATH:BOOL=OFF
7676
-DCMAKE_SKIP_INSTALL_RPATH:BOOL=OFF
7777
-DMACOSX_RPATH:BOOL=ON
78-
-DCMAKE_INSTALL_RPATH:PATH=${install_prefix}/lib${LIB_SUFFIX}
78+
-DCMAKE_INSTALL_RPATH:PATH=${install_prefix}/${CMAKE_INSTALL_LIBDIR}
7979
-DCMAKE_INSTALL_PREFIX:PATH=${install_prefix}
8080
"-DCMAKE_CXX_FLAGS_RELEASE:STRING=${NIFTI_CMAKE_CXX_FLAGS_RELEASE}"
8181
"-DCMAKE_C_FLAGS_RELEASE:STRING=${NIFTI_CMAKE_C_FLAGS_RELEASE}"
@@ -95,9 +95,9 @@ macro(build_nifti install_prefix staging_prefix)
9595
INSTALL_DIR ${staging_prefix}/${install_prefix}
9696
)
9797

98-
set(NIFTI_LIBRARY ${staging_prefix}/${install_prefix}/lib${LIB_SUFFIX}/libniftiio.a )
98+
set(NIFTI_LIBRARY ${staging_prefix}/${install_prefix}/${CMAKE_INSTALL_LIBDIR}/libniftiio.a )
9999
set(NIFTI_INCLUDE_DIR ${staging_prefix}/${install_prefix}/include/nifti )
100-
set(ZNZ_LIBRARY ${staging_prefix}/${install_prefix}/lib${LIB_SUFFIX}/libznz.a )
100+
set(ZNZ_LIBRARY ${staging_prefix}/${install_prefix}/${CMAKE_INSTALL_LIBDIR}/libznz.a )
101101
set(ZNZ_INCLUDE_DIR ${staging_prefix}/${install_prefix}/include/nifti )
102102
set(NIFTI_FOUND ON)
103103

ezminc/examples/Example_CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
# Example CMakeLists.txt to work with minc&EZminc
22

3+
cmake_minimum_required(VERSION 2.8...4.0)
34

45
project(EXAMPLE)
5-
cmake_minimum_required(VERSION 2.8)
66

77
find_package(LIBMINC REQUIRED)
88
include( ${LIBMINC_USE_FILE} )

0 commit comments

Comments
 (0)