Skip to content

[PC TV] Smooth out transitions between main screens #4612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SergioEstevao merged 2 commits into from
Jun 25, 2026
+13 −3
Merged

[PC TV] Smooth out transitions between main screens #4612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aab02a3
Adjust animations to use smooth and avoid bounces that show previous …
SergioEstevao Jun 25, 2026
c33b8e2
Ensure event of application opened is sent on the first start before …
SergioEstevao Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Pocket Casts TV App/PocketCastsTVApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ struct PocketCastsTVApp: App {
var body: some Scene {
WindowGroup {
RootView()
.task {
appLifecycleAnalytics.didBecomeActive()
}
}
.onChange(of: scenePhase) { _, newPhase in
appLifecycleAnalytics.handle(scenePhase: newPhase)
Expand Down
2 changes: 1 addition & 1 deletion Pocket Casts TV App/UI/Auth/SigningInView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ struct SigningInView<ViewModel: SigningInViewModelProtocol>: View {
}
Color.pcBackgroundSunken
.opacity(blackOverlayOpaque ? 1 : 0)
.animation(reduceMotion ? nil : .easeInOut(duration: Pacing.fadeDuration), value: blackOverlayOpaque)
.animation(reduceMotion ? nil : .smooth, value: blackOverlayOpaque)
.allowsHitTesting(false)
Comment on lines 71 to 74
.ignoresSafeArea()
}
Expand Down
11 changes: 9 additions & 2 deletions Pocket Casts TV App/UI/RootView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,27 @@ struct RootView: View {
Spacer()
ProgressView()
Spacer()
}.frame(maxWidth: .infinity)
}
.frame(maxWidth: .infinity)
.transition(.opacity)
case .welcome:
WelcomeView()
.transition(.opacity)
case .browsing, .signedIn:
MainTabView()
.transition(.opacity)
case .userSync:
SigningInView()
.transition(.opacity)
case .dataLossResync:
DataLossResyncView()
.transition(.opacity)
case .serverSignedOut:
UserSignedOutView()
.transition(.opacity)

@kean kean Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nit) if you want to apply them everywhere, I'd suggest using Group

}
}
.animation(.easeInOut, value: coordinator.state)
.animation(.smooth, value: coordinator.state)
.environment(coordinator)
Comment on lines 34 to 36
.environment(focusStore)
.task {
Expand Down