[PC TV] Smooth out transitions between main screens#4612
Open
SergioEstevao wants to merge 2 commits into
Open
Conversation
Collaborator
Generated by 🚫 Danger |
SergioEstevao
requested review from
Copilot and
kean
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Pocket Casts TV app root-level screen transitions to avoid briefly flashing the previous screen when moving between major app states (loading/welcome/sign-in/main/etc).
Changes:
- Added explicit
.transition(.opacity)to eachRootViewstate case and changed the driving animation oncoordinator.stateupdates to.smooth. - Updated
SigningInView’s black overlay fade animation to use.smooth(instead of a timed.easeInOut) to reduce bounce/flash risk during sign-in handoff.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Pocket Casts TV App/UI/RootView.swift | Adds opacity transitions per state and switches the state-change animation to .smooth. |
| Pocket Casts TV App/UI/Auth/SigningInView.swift | Adjusts the black overlay fade animation curve used during the sync/sign-in flow. |
Comment on lines
34
to
36
| } | ||
| .animation(.easeInOut, value: coordinator.state) | ||
| .animation(.smooth, value: coordinator.state) | ||
| .environment(coordinator) |
Comment on lines
71
to
74
| Color.pcBackgroundSunken | ||
| .opacity(blackOverlayOpaque ? 1 : 0) | ||
| .animation(reduceMotion ? nil : .easeInOut(duration: Pacing.fadeDuration), value: blackOverlayOpaque) | ||
| .animation(reduceMotion ? nil : .smooth, value: blackOverlayOpaque) | ||
| .allowsHitTesting(false) |
kean
approved these changes
Jun 25, 2026
| .transition(.opacity) | ||
| case .serverSignedOut: | ||
| UserSignedOutView() | ||
| .transition(.opacity) |
Contributor
There was a problem hiding this comment.
(nit) if you want to apply them everywhere, I'd suggest using Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the transitions between the main screens of the Pocket Casts TV app so switching between the loading, welcome, main tab, sign-in, data-loss-resync, and signed-out states feels smoother and no longer briefly flashes the previous screen.
Changes:
RootView: each state case now uses an explicit.transition(.opacity)and the rootanimationdrivingcoordinator.statechanges was switched from.easeInOutto.smooth.SigningInView: the black overlay fade now uses.smoothinstead of.easeInOut(duration:), avoiding the bounce that could reveal the previous screen.To test
Checklist
CHANGELOG.mdif necessary.