Skip to content

[PC TV] Add home_shown and sign_in_type_tapped analytics events #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kean merged 1 commit into from
Jun 25, 2026
+6 −0
Merged

[PC TV] Add home_shown and sign_in_type_tapped analytics events #4607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Pocket Casts TV App/UI/Auth/SignInView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,9 @@ struct SignInView: View {
model.state = .start
}
}
.onChange(of: loginType) {
Analytics.track(.signInTypeTapped, properties: ["type": loginType == .qr ? "qr" : "password"])
}
.onChange(of: model.state) {
switch model.state {
case .finished:
Expand Down
1 change: 1 addition & 0 deletions Pocket Casts TV App/UI/Home/HomeView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ struct HomeView: View {
}
.animation(.easeInOut, value: model.state)
.task {
Analytics.track(.homeShown)
model.load()
}
}
Expand Down
2 changes: 2 additions & 0 deletions podcasts/Analytics/AnalyticsEvent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ enum AnalyticsEvent: String {

case signInShown
case signInDismissed
case signInTypeTapped // tvOS: switching between QR code and password sign-in

// MARK: - Select Account Type

Expand Down Expand Up @@ -416,6 +417,7 @@ enum AnalyticsEvent: String {

// MARK: - Discover

case homeShown // tvOS Home tab
case discoverShown
case discoverCategoryShown
case discoverCategoriesPillTapped
Expand Down
Loading