Skip to content

[PC TV] Add home_shown and sign_in_type_tapped analytics events#4607

Merged
kean merged 1 commit into
trunkfrom
kean/tvos-home-and-signin-type-analytics
Jun 25, 2026
Merged

[PC TV] Add home_shown and sign_in_type_tapped analytics events#4607
kean merged 1 commit into
trunkfrom
kean/tvos-home-and-signin-type-analytics

Conversation

@kean

@kean kean commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Fixes PCIOS-793.

Wires up two new tvOS-only analytics events:

  • home_shown — fired when the Home tab appears (HomeView .task).
  • sign_in_type_tapped — fired when the user switches the sign-in picker between QR code and password (SignInView .onChange(of: loginType)), with a type property of qr or password.

Schema changes are in Automattic/EventHorizonSchemas#93.

To test

  1. Run the Pocket Casts TV App target on the tvOS simulator.
  2. Watch the console for AnalyticsLoggingAdapter output.
  3. From the logged-out state, open Sign In and toggle the picker between QR Code and Password → each switch logs sign_in_type_tapped with type = qr / password.
  4. Sign in and land on the Home tab → home_shown is logged when Home appears.

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the Event Horizon schema to reflect any new or changed analytics.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings June 24, 2026 21:31
@kean kean requested a review from a team as a code owner June 24, 2026 21:31
@kean kean added this to the 8.16 milestone Jun 24, 2026
@kean kean added [Type] Enhancement Improve an existing feature. Analytics Analytics related issues labels Jun 24, 2026
@kean kean requested review from SergioEstevao and removed request for a team June 24, 2026 21:31
@kean kean added [Type] Enhancement Improve an existing feature. Analytics Analytics related issues labels Jun 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@dangermattic

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@SergioEstevao SergioEstevao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New events being sent.

Remember to add them to Event Horizon :)

@kean kean merged commit 2b5486e into trunk Jun 25, 2026
8 of 13 checks passed
@kean kean deleted the kean/tvos-home-and-signin-type-analytics branch June 25, 2026 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Analytics Analytics related issues [Type] Enhancement Improve an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants