Skip to content

fix(Tweaks): "Hide filtered posts entirely" breaking if endless scrolling is disabled #2285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcustyphoon wants to merge 6 commits into
base: master
Choose a base branch
from
+4 −8
Open

fix(Tweaks): "Hide filtered posts entirely" breaking if endless scrolling is disabled #2285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d2c4e90
fix: make getTimelineItemWrapper idempotent
marcustyphoon Jun 12, 2026
9306b7b
fix: do something normal in filtered posts tweak
marcustyphoon Jun 12, 2026
414f480
Apply suggestions from code review
marcustyphoon Jun 12, 2026
5fdc3b5
lint
marcustyphoon Jun 12, 2026
ecdc466
fix: remove margin from hidden posts
AprilSylph Jun 12, 2026
dd54732
refactor: max simplification of `getTimelineItemWrapper`
AprilSylph Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/tweaks/hide_filtered_posts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { keyToCss } from '../../utils/css_map.js';
import { createPostHideFunctions } from '../../utils/hide_posts.js';
import { getTimelineItemWrapper } from '../../utils/interface.js';
import { postSelector } from '../../utils/interface.js';
import { pageModifications } from '../../utils/mutations.js';

const { hidePost, showPosts } = createPostHideFunctions({
Expand All @@ -11,7 +11,7 @@ const { hidePost, showPosts } = createPostHideFunctions({
});

const hideFilteredPosts = filteredScreens => filteredScreens
.map(getTimelineItemWrapper)
.map(filteredScreen => filteredScreen.closest(postSelector))
.forEach(hidePost);

export const main = async function () {
Expand Down
1 change: 1 addition & 0 deletions src/utils/hide_posts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ export const createPostHideFunctions = ({ id, permalinkPageControls }) => {
[${hiddenAttribute}], [${controlsAttribute}] ~ div [${controlledHiddenAttribute}] {
content: linear-gradient(transparent, transparent);
height: 0;
margin: 0 !important;
}
`;

Expand Down
7 changes: 1 addition & 6 deletions src/utils/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ export const trailItemSelector = `${postSelector} ${keyToCss('reblog')}`;
export const blogViewSelector = '[style*="--blog-title-color"] *';
export const notificationSelector = `:is(${keyToCss('notification')}[role="listitem"], ${keyToCss('activityItem')})`;

const listTimelineObjectSelector = keyToCss('listTimelineObject');
const cellSelector = keyToCss('cell');
const targetWrapperSelector = keyToCss(
'targetWrapper',
'targetWrapperBlock',
Expand All @@ -21,10 +19,7 @@ const targetWrapperSelector = keyToCss(
* @param {Element} element Element within a timeline item
* @returns {Element | null} The timeline item wrapper
*/
export const getTimelineItemWrapper = element =>
(element.closest('[data-timeline-id]') && element.closest(listTimelineObjectSelector)?.parentElement) ||
element.closest(cellSelector) ||
element.closest(listTimelineObjectSelector);
export const getTimelineItemWrapper = element => element.closest(`${timelineSelector} > div > div`);

/**
* @param {Element} element Element within a popover wrapper
Expand Down