fix(Tweaks): "Hide filtered posts entirely" breaking if endless scrolling is disabled

[marcustyphoon]

Description

This fixes filtered posts not being hidden if endless scrolling is disabled.

The cause for this was that (as I noted in #2132) the code was, to appear more semantically correct, calling getTimelineItemWrapper twice. I thought the utility function was idempotent (could be called repeatedly with the same result), and when the resulting code worked I didn't think about it further, but it actually wasn't idempotent with endless scrolling disabled.

This PR makes two changes, either of which fix the problem alone: a) getTimelineItemWrapper no longer crashes if called multiple times with endless scrolling disabled, and b) the filtered post hiding feature no longer calls it multiple times.

Resolves #2284.

Testing steps

Confirm that filtered posts are hidden both with and without endless scrolling enabled.

[marcustyphoon]

Will that break on stuff with data-timeline?

[AprilSylph]

Timeline V1s don't have cells, so the existing .closest(listTimelineObjectSelector) should suffice for them. The new code is literally "find the wrapper in Timeline V2; fall back to finding the wrapper in Timeline V1". Should double-check that nothing is broken on Queue pages to be sure of this.

[marcustyphoon]

Tempted to do, like, :is(${keyToCss('cell')}, :not([class])), but maybe that's excessive.

[AprilSylph]

Tested and working:

• hide_filtered_posts on dashboard, endless scrolling enabled
• hide_filtered_posts on dashboard, endless scrolling disabled
• hide_filtered_posts on permalink view, endless scrolling enabled
• hide_filtered_posts on permalink view, endless scrolling disabled
• PostBlock on dashboard
• PostBlock on permalink view
• PostBlock on Queue

[marcustyphoon]

Do we need to apply that margin change to the other features that hide posts?

[AprilSylph]

Only PostBlock needs the margin override, but only by coincidence—no other post-hiding feature targets elements found in the queue. If Tumblr decided to start showing filtered screens on your own posts, it would be needed for hide_filtered_posts as well.

TIL: Timeline V1s that are not the queue (e.g. https://www.tumblr.com/timeline/blog_subscriptions) are also using virtualisation now?? Seems we could simplify even further:

export const getTimelineItemWrapper = element => element.closest(`${timelineSelector} > div > div`);

[marcustyphoon]

Hm, I don't know how to be confident about this. I guess we have grid, masonry, queue, endless scrolling on and off for each... I think the code technically implies that scrollContainer is optional but I don't know when that would ever be used... tumblr patio is probably normal? Surely it's fine.