Skip to content

fix(core): enhance empty string expression validation error context (#8762) #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
subbareddypalagiri wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −8
Open

fix(core): enhance empty string expression validation error context (#8762) #8765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f814b92
fix(core): enhance empty string expression validation error context (…
subbareddypalagiri Jun 25, 2026
8eade80
test: update assertions to match the new error context
subbareddypalagiri Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/GDCore/IDE/Events/ExpressionValidator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ class GD_CORE_API ExpressionValidator : public ExpressionParser2NodeWorker {
message = _("You must enter a number or a valid expression call.");
} else if (parentType == Type::String) {
message = _(
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");
} else if (parentType == Type::Variable || parentType == Type::LegacyVariable) {
message = _("You must enter a variable name.");
} else if (parentType == Type::Object) {
Expand Down
12 changes: 6 additions & 6 deletions Core/tests/ExpressionParser2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
node->Visit(validator);
REQUIRE(validator.GetFatalErrors().size() == 1);
REQUIRE(validator.GetFatalErrors()[0]->GetMessage() ==
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");
}
SECTION("of type number") {
auto node = parser.ParseExpression("");
Expand Down Expand Up @@ -306,7 +306,7 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
REQUIRE(validator.GetFatalErrors().size() == 1);
REQUIRE(
validator.GetFatalErrors()[0]->GetMessage() ==
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");
}
{
auto node = parser.ParseExpression("abcd");
Expand Down Expand Up @@ -473,7 +473,7 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
"You must add the operator + between texts or expressions. For "
"example: \"Your name: \" + VariableString(PlayerName).");
REQUIRE(validator.GetFatalErrors()[2]->GetMessage() ==
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");

REQUIRE(validator.GetFatalErrors()[1]->GetMessage() ==
"The expression has extra character at the end that should be "
Expand All @@ -492,7 +492,7 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
"You must add the operator + between texts or expressions. For "
"example: \"Your name: \" + VariableString(PlayerName).");
REQUIRE(validator.GetFatalErrors()[2]->GetMessage() ==
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");

REQUIRE(validator.GetFatalErrors()[1]->GetMessage() ==
"The expression has extra character at the end that should be "
Expand Down Expand Up @@ -535,7 +535,7 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
REQUIRE(validator.GetFatalErrors().size() == 1);
REQUIRE(
validator.GetFatalErrors()[0]->GetMessage() ==
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");
}
}

Expand Down Expand Up @@ -570,7 +570,7 @@ TEST_CASE("ExpressionParser2", "[common][events]") {
"The expression has extra character at the end that should be "
"removed (or completed if your expression is not finished).");
REQUIRE(validator.GetFatalErrors()[3]->GetMessage() ==
"You must enter a text (between quotes) or a valid expression call.");
"You must enter a text (between quotes) or a valid expression call. Please check your event parameters.");
}
}

Expand Down
2 changes: 1 addition & 1 deletion GDevelop.js/__tests__/Core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3984,7 +3984,7 @@ describe('libGD.js', function () {
testExpression(
'string',
'="Mynewscene"',
'You must enter a text (between quotes) or a valid expression call.',
'You must enter a text (between quotes) or a valid expression call. Please check your event parameters.',
0
);
});
Expand Down