Skip to content

fix(core): enhance empty string expression validation error context (#8762)#8765

Open
subbareddypalagiri wants to merge 2 commits into
4ian:masterfrom
subbareddypalagiri:fix-issue-8762-empty-string
Open

fix(core): enhance empty string expression validation error context (#8762)#8765
subbareddypalagiri wants to merge 2 commits into
4ian:masterfrom
subbareddypalagiri:fix-issue-8762-empty-string

Conversation

@subbareddypalagiri

Copy link
Copy Markdown

This PR adds a protective context message to the ExpressionValidator to help users debug empty string issues efficiently, addressing the spam mentioned in Issue #8762.

@subbareddypalagiri subbareddypalagiri requested a review from 4ian as a code owner June 25, 2026 10:30
@4ian

4ian commented Jun 25, 2026

Copy link
Copy Markdown
Owner

An expression is not necessarily an event parameter, it can be used also in a event for example as the number of repeat for a repeat event or a limit in a for each.
So I think updating this error message is not the right solution :)

@subbareddypalagiri

Copy link
Copy Markdown
Author

Thank you for the valuable feedback! I understand now that expressions can be used in various contexts within an event (e.g., repeat counts, limits) and are not exclusively instruction parameters. My previous change to make the error message more specific to 'parameters' was indeed incorrect and narrowed the context too much.

I've reverted the change to this error message to keep it general, ensuring it's applicable across all expression usages. I'll be more mindful of the broader context of expressions in future validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants