Add WorkflowCancel implementation (#472)#532
Open
jsamaniego4 wants to merge 1 commit into
Open
Conversation
Signed-off-by: jsamaniego4 <158121098+jsamaniego4@users.noreply.github.com>
jsamaniego4
force-pushed
the
feature/issue-472-workflow-cancel
branch
from
f72ea6e to
c9c6098
Compare
| request = ZosmfRequestFactory.buildRequest(connection, ZosmfRequestType.PUT_JSON); | ||
| } | ||
| request.setUrl(url); | ||
| request.setBody("{}"); |
Collaborator
There was a problem hiding this comment.
remove setBody if none needs to be provided.
| request.setUrl(url); | ||
| request.setBody("{}"); | ||
|
|
||
| return request.executeRequest(); |
Collaborator
There was a problem hiding this comment.
The IBM documentation indicates that the service returns a JSON response. For example:
HTTP/1.1 200 OK
content-length: 59
content-language: en-US
x-powered-by: Servlet/3.0
server: WebSphere Application Server
connection: Close
date: Wed, 11 Feb 2015 18:30:33 GMT
content-type: application/json; charset=UTF-8
{
"workflowName": "AutomationExample|Canceled|1423679433714"
}
To handle this properly, a dedicated response model should be introduced. For instance, create a WorkflowCancelResponse class containing a single field, workflowName.
The service layer should then deserialize the JSON payload into this object and return it to the caller, rather than exposing raw JSON.
frankgiordano
requested changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #472
Provide a workflow API method to cancel a z/OSMF workflow on a z/OS system.
Implementation supports the z/OSMF Cancel Workflow REST API: