Conversation
A while loop on !ct.IsCancellationRequested becomes while (true) in the synchronized version. Unless something else leaves the loop it never ends, and the statements after it can't be reached, which the compiler reports as CS0162 in the generated file. Generated with Claude Code
A cancellation check in a while loop's condition becomes true once synchronized. When nothing else leaves the loop - a break belonging to it, a return, throw, yield break, goto, or a call to a [DoesNotReturn] method - report ZSMGEN006. When no break leaves it, drop the statements after it too, since they can't be reached. The loop is judged on its rewritten body, because the rewrite also drops checks such as if (ct.IsCancellationRequested) break;. Based on #69. Generated with Claude Code Co-authored-by: Gerard Smit <gsmit1996@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
==========================================
- Coverage 93.47% 92.28% -1.19%
==========================================
Files 10 11 +1
Lines 1593 1647 +54
Branches 374 380 +6
==========================================
+ Hits 1489 1520 +31
- Misses 26 45 +19
- Partials 78 82 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Moved into #69 so the commit stays Gerard's. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #69 by @GerardSmit, reworked for current master.
A
while (!ct.IsCancellationRequested)loop becomeswhile (true)once synchronized. When nothing else leaves it (break,return,throw,yield break,goto, or a[DoesNotReturn]call) the generator now reports ZSMGEN006, and statements after a loop nobreakleaves are dropped, since they're unreachable (CS0162).Generated with Claude Code