Skip to content

CLI: improve GitHub API failure guidance for audit errors#1730

Closed
SergioChan wants to merge 1 commit into
zizmorcore:mainfrom
SergioChan:fix-1252-rate-limit-error-guidance
Closed

CLI: improve GitHub API failure guidance for audit errors#1730
SergioChan wants to merge 1 commit into
zizmorcore:mainfrom
SergioChan:fix-1252-rate-limit-error-guidance

Conversation

@SergioChan

@SergioChan SergioChan commented Mar 9, 2026

Copy link
Copy Markdown

Summary

  • add a targeted fatal help block when an audit fails due to GitHub API access/rate-limit style errors (for example HTTP 403 or 'couldn't list tags')
  • keep the existing underlying error chain, but provide immediate actionable guidance to reduce confusion
  • suggest token configuration and offline mode as recovery paths

Testing

  • Not run locally in this environment because the Rust toolchain is unavailable (cargo: command not found), so I could not execute the test suite.
  • Change is intentionally minimal and isolated to error-report rendering in main.rs for Error::Audit.

Related

Fixes #1252

@woodruffw woodruffw left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this.

Multiple things here:

  1. You haven't filled out the required template for PRs. This template is mandatory.
  2. You haven't engaged at all with the discussion in #1252, or the current PR in #1609.
  3. Your PR isn't at all general -- it doesn't handle rate limiting outside of audits, or properly distinguish between GitHub origins and other origins.

@woodruffw woodruffw closed this Mar 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI: improve error message on rate limiting from GitHub

2 participants