Rename main client class to Zitadel::Client for API consistency#37
Merged
Conversation
bd968ea to
f16af1c
Compare
Contributor
Qodana for PHPIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
This PR addresses the naming convention of the main public API class in the Ruby SDK. Specifically:
Zitadel::ZitadelClientor a similar variation) was less aligned with the desired concise naming strategy for SDK components.How the Problems Are Solved
The primary SDK class has been refined to improve clarity and consistency:
Clientand ensured it is properly namespaced under the top-levelZitadelmodule. The fully qualified name for the main class is nowZitadel::Client.lib/zitadel/zitadel_client.rbor similar tolib/zitadel/client.rb).Zitadel::Client.new(...)orZitadel::Client.withPrivateKey(...)), and method calls throughout the SDK to use the newZitadel::Clientclass.Additional Changes
To support the primary renaming and ensure a smooth transition:
Zitadel::Clientand its usage.Zitadel::Client.lib/zitadel.rb) correctly requires and loads the renamed client class file.Additional Context
This renaming to
Zitadel::Clienthelps align the Ruby SDK's namespace and class structure with patterns used in our other SDKs, promoting consistency across the Zitadel ecosystem:Clientidentifier as the primary class name within the mainZitadelmodule. This is conceptually similar to how the PHP SDK organizes its client under aZitadel\Clientnamespace structure.Zitadelmodule for the gem, which is akin to thecom.zitadelbase package in the Java SDK and theZitadelvendor namespace in PHP.You can also add specific issue links if they apply: