feat: define Milvus metadata cataLog boundary#1
Open
shaoting-huang wants to merge 4 commits into
Open
Conversation
shaoting-huang
force-pushed
the
pr/readme-v2
branch
from
fca60b4 to
b17280f
Compare
shaoting-huang
changed the title
shaoting-huang
force-pushed
the
pr/readme-v2
branch
from
b17280f to
ac42066
Compare
shaoting-huang
force-pushed
the
pr/readme-v2
branch
5 times, most recently
from
e5d7d14 to
079e5ca
Compare
1. Define pkg/catalog as the canonical domain-first Catalog API with Metadata, AccessControl, InternalState, and Migration domains. 2. Add pkg/milvuscompat adapters that expose Milvus RootCoord, DataCoord, QueryCoord, StreamingCoord, and StreamingNode catalog interfaces on top of catalog.Catalog. Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
shaoting-huang
force-pushed
the
pr/readme-v2
branch
from
079e5ca to
939bd15
Compare
shaoting-huang
changed the title
- Remove MoveDatabase from CollectionCatalog; Alter handles DB changes with full-struct passthrough to prevent field loss when collections move between databases (regression test in full_struct_test.go) - Add PartitionID filtering to wrappedSegments.List - Add ErrNotWired sentinel separating wiring errors from spec gaps - Surface ctx.Err() in 4 bool wrap methods so context cancellation doesn't silently become false - Document SnapshotCatalog Get/ListManifests as compat-layer reserved - Mark pkg/catalog as EXPERIMENTAL until v1.0 - CI: enable race detector - Drop unused pkg/api/ deprecated alias - Switch module path from milvus-io/milvus-catalog to zilliztech/milvus-catalog to match the actual repository URL Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Follow-up to milvus rename: streamingcoord/node interface name typo (CataLog -> Catalog) was fixed upstream in pkg/v3/metastore. Update milvuscompat references accordingly and bump the milvus pkg/v3 dependency to the rename commit. Generated with [Claude Code](https://claude.ai/code) via [Happy](https://happy.engineering) Co-Authored-By: Claude <noreply@anthropic.com> Co-Authored-By: Happy <yesreply@happy.engineering> Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
Summary: - Run gofmt on the four milvuscompat files reported by CI. - Reorder the local catalog import according to gofmt output. Rationale: - PR #1 was failing the CI gofmt check because these files were not in canonical Go formatting. - The change is formatting-only and does not alter business logic. Tests: - gofmt -l . - go vet ./... - go test ./... - go build ./... - go test -race ./... Co-authored-by: Codex <codex@openai.com>
Collaborator
Author
|
Codex update for ENG-1:
Local validation:
Note: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a stable metadata catalog boundary for Milvus and wire the existing five coordinator catalogs through it.
This keeps the current etcd/TiKV-backed behavior unchanged while making the catalog backend replaceable later.
Changes
pkg/metastore.milvus-catalogdomain interfaces and compatibility adapters.Current path: