Skip to content

fix: firefox playwright support #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zikani03 merged 1 commit into from
Jun 2, 2026
Merged

fix: firefox playwright support #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions playwright/playwright.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,14 @@ func (e *Executor) Run(ctx context.Context) (interface{}, error) {
}

var browser playwrightgo.Browser
var browserEngine playwrightgo.BrowserType

if e.Browser == "firefox" {
browserEngine = pw.Firefox
} else { // defaults to chromium on any other case
browserEngine = pw.Chromium
}

if e.CDPEndpoint != "" {
// In order to support platforms like cloudflare, we need to allow users to be able to pass
// options like headers to the CDP options. The best way is probably to expose this somehowm but...
Expand All @@ -133,11 +141,12 @@ func (e *Executor) Run(ctx context.Context) (interface{}, error) {
return nil, fmt.Errorf("failed to parse CDP_HEADERS: %v", err)
}
}
browser, err = pw.Chromium.ConnectOverCDP(e.CDPEndpoint, playwrightgo.BrowserTypeConnectOverCDPOptions{

browser, err = browserEngine.ConnectOverCDP(e.CDPEndpoint, playwrightgo.BrowserTypeConnectOverCDPOptions{
Headers: cdpHeadersFromEnv,
})
} else {
browser, err = pw.Chromium.Launch(playwrightgo.BrowserTypeLaunchOptions{
browser, err = browserEngine.Launch(playwrightgo.BrowserTypeLaunchOptions{
Headless: playwrightgo.Bool(e.Headless), // should we expose this option?
})
}
Expand Down
Loading