refactor: change Repository interface argument from UseCommand to UserEntity#504
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/user #504 +/- ##
===============================================
+ Coverage 58.06% 58.36% +0.29%
- Complexity 1453 1460 +7
===============================================
Files 112 112
Lines 7383 7426 +43
===============================================
+ Hits 4287 4334 +47
+ Misses 3096 3092 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The
UserRepositroyInterfacewas acceptingCreateUserCommand(Application layer) as its argument, which violates DDD layering — the Domain layer must not depend on the Application layer.What I have done
UserEntity: makeidnullable (?int) to represent a not-yet-persisted entity; addpasswordHashfield andgetPasswordHash()getterUserEntityFactory: supportid: nullandpassword_hashkeyUserRepositroyInterface: changecreateUser(CreateUserCommand)→createUser(UserEntity)UserRepository: use entity getters; password hashing moved from Repository to UseCaseCreateUserUseCase: buildUserEntityviaUserEntityFactory(bcrypt applied here) before passing to repositoryTest Results
UserRepositoryTest: moved toapp/Packages/Domains/Tests/, updated to buildUserEntityvia factoryUserEntityTest: added tests for nullableidandgetPasswordHash()UserEntityFactoryTest: added tests forpassword_hashkey and nullableidCreateUserUseCaseTest: verifiesUserEntityis passed to repository