test: add unit tests for factories and UserEntity to improve patch coverage / FactoryとUserEntityのユニットテストを追加してパッチカバレッジを改善#498
Merged
zigzagdev merged 4 commits intoJun 28, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/user_register #498 +/- ##
=====================================================
Coverage 55.40% 55.40%
Complexity 1409 1409
=====================================================
Files 102 102
Lines 7039 7039
=====================================================
Hits 3900 3900
Misses 3139 3139 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 目的
After PR #497, Codecov still reported 69.89% patch coverage (target 85%). Investigation showed the following source files had no unit tests covering them.
PR #497 マージ後も Codecov のパッチカバレッジが 69.89%(目標 85%)のままでした。以下のソースファイルにユニットテストが不足していることが原因と判明しました。
What I have done / 実施内容
SubscriptionFactoryTest: coversbuild()with null/string/DateTimeImmutableexpires_at, string/DateTimeImmutablenow(5 tests)UserEntityFactoryTest: coversbuild()creating correctUserEntitywith Free and Premium subscriptions (2 tests)UserEntityTest: covers all getters includinggetFullName()(7 tests)UserViewModelFactoryTest: coversbuild()returningUserViewModelinstance (1 test)Test Results / テスト結果
All new tests pass. Previous 26 tests + 15 new = 41 unit tests total.
Closes part of #400