Repository navigation
feat: add temporal-aware http caller - #14
Merged
Merged
Conversation
mrsimonemms
force-pushed
the
sje/call-http-activity
branch
from
October 14, 2026 16:25
a548fac to
c79d197
Compare
This exists to simplify making HTTP calls in a Temporal Go application. The reason this is useful is because HTTP returns response which impact on how Temporal should handle retries etc. Signed-off-by: Simon Emms <simon@simonemms.com>
mrsimonemms
force-pushed
the
sje/call-http-activity
branch
from
October 14, 2026 17:41
c79d197 to
59c85c8
Compare
Codex PR ReviewNo blocking issues. Ship it. Review covered Go 1.26 compatibility, the implementation and its tests. Tests could not run locally because the read-only filesystem prevented Go from initialising its caches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A reusable HTTP struct that's Temporal-aware
Related issue
Fixes #
How to test
Checklist
Fixes #...,Closes #...orRelates to #...