Skip to content

Swift iOS fixes#4966

Merged
externl merged 3 commits into
zeroc-ice:3.7from
externl:3.7-swift-ios-fixes
Jan 28, 2026
Merged

Swift iOS fixes#4966
externl merged 3 commits into
zeroc-ice:3.7from
externl:3.7-swift-ios-fixes

Conversation

@externl

@externl externl commented Jan 27, 2026

Copy link
Copy Markdown
Member

This PR removes Carthage support from our Swift Rakefile and includes a fix for launching the TestDriver iOS app.

Fixes #4963
Fixes #4964

Copilot AI review requested due to automatic review settings January 27, 2026 19:39
@externl
externl changed the base branch from main to 3.7 January 27, 2026 19:39
@externl
externl requested a review from pepone January 27, 2026 19:41
Comment thread swift/Rakefile
config.build_settings["GCC_SYMBOLS_PRIVATE_EXTERN"] = "YES"
config.build_settings["ENABLE_TESTABILITY"] = "NO"
config.build_settings["GCC_TREAT_WARNINGS_AS_ERRORS"] = "YES"
config.build_settings["DISABLE_MANUAL_TARGET_ORDER_BUILD_WARNING"] = "YES"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was getting a warning in Xcode without this.

Comment thread swift/Rakefile
test_scheme = Xcodeproj::XCScheme.new
test_scheme.add_build_target(test_driver_target)
test_scheme.build_action.parallelize_buildables = false
test_scheme.set_launch_target(test_driver_target)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the fix for launching the iOS app.

@pepone pepone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@externl
externl merged commit 6c66b42 into zeroc-ice:3.7 Jan 28, 2026
43 of 45 checks passed
@externl externl mentioned this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bogus call to ERR_get_error

3 participants