Skip to content

Fix sn.exe not found in PATH during strong name signing #4923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pepone merged 2 commits into from
Jan 22, 2026
Merged

Fix sn.exe not found in PATH during strong name signing #4923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4673f22
Fix sn.exe not found in PATH during strong name signing
pepone Jan 22, 2026
b9951bc
Fix upload path
pepone Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/build-dotnet-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,15 @@ jobs:
# Set environment variables for the build
echo "PUBLIC_KEYFILE=${{ github.workspace }}\csharp\msbuild\ice-release-pub-key.snk" >> $env:GITHUB_ENV
echo "KEYFILE=${{ github.workspace }}\csharp\msbuild\ice-release-key.snk" >> $env:GITHUB_ENV

# Add the .NET Framework SDK tools directory to PATH for sn.exe (strong name tool)
$sdkToolsPath = "${env:ProgramFiles(x86)}\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.8.1 Tools"
if (Test-Path $sdkToolsPath) {
Write-Host "Adding $sdkToolsPath to PATH"
echo $sdkToolsPath >> $env:GITHUB_PATH
} else {
Write-Host "Warning: .NET Framework SDK tools path not found at $sdkToolsPath"
}
} else {
Write-Host "Strong name signing keys not configured - assemblies will not be signed"
}
Expand Down Expand Up @@ -172,5 +181,5 @@ jobs:
with:
name: dotnet-nuget-packages
path: |
csharp/msbuild/zeroc.ice.net/*.nupkg
csharp/msbuild/zeroc.ice.net/*.snupkg
csharp/msbuild/*.nupkg
csharp/msbuild/*.snupkg