Skip to content

EquipmentTreeBuilder no longer overwrites existing leaves with children. - #244

Merged
kgreav merged 1 commit into
mainfrom
equipment-tree-fix
Oct 1, 2026
Merged

kgreav merged 1 commit into
mainfrom
equipment-tree-fix

Conversation

@chestm007

Copy link
Copy Markdown
Contributor

Description

does that it says on the tin.

Test Steps

None really - i added a test for this, and the others are all unchanged so im sure its fine

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@kgreav
kgreav merged commit 306fbb7 into main Oct 1, 2026
9 checks passed
@kgreav
kgreav deleted the equipment-tree-fix branch October 1, 2026 06:10
kgreav pushed a commit that referenced this pull request Oct 2, 2026
…en. (#244)

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants