[pull] master from linux-nvme:master#242
Merged
Merged
Conversation
The Coverity service is back again. Let's add it back then. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Curl is already used, so there is no need to depend on a second download tool. Since wget is often not installed by default, replace it with curl. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The upload job depends on this name. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The test runner wrapped the command in "if ! cmd; then rc=$?". Because $? reflects the result of the negated expression rather than the command itself, it was always 0 when the branch was taken: a test binary that genuinely failed was reported as passing, masking real command-level failures. Run the command first, capture its status, then test it, so the real exit code is preserved and propagated. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
The orchestrator identity (the "owner" recorded in the controller ownership registry) is a global-context property that could be set via the API or the CLI, but it was never written to the JSON config, so it was lost whenever the config was rewritten. Record it as a top-level "owner" key so it round-trips through the config file. On read the config's owner is adopted only when the context has none, so an explicit CLI --owner still wins. On write it is emitted whenever set. Extend the schema with the new key and add a round-trip test fixture. Suggested-by: Daniel Wagner <wagi@kernel.org> Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Signed-off-by: Daniel Wagner <wagi@kernel.org>
Signed-off-by: Daniel Wagner <wagi@kernel.org>
Use a dynamically determined transfer size when retrieving the host and controller telemetry logs to avoid invalid argument error. Signed-off-by: jeff-lien-sndk <jeff.lien@sandisk.com>
…atures() sedopal_print_locking_features() dereferences @ld without checking whether it is NULL. Add a NULL check before accessing ld->features and print an error message when no locking feature information is available. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
The get_log_offset() function stores the command result via args->result after retrieving the log page. However, the pointer args->result was dereferenced without first checking if it is NULL. Dereferencing a NULL args->result pointer causes a crash when callers pass NULL to indicate they do not need the result value. Check if args->result is non-NULL before dereferencing it to store the command result. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
libnvme_rescan_ctrl() derives the global context from the controller. The derived @ctx is then passed to libnvme_ctrl_scan_namespaces() and libnvme_ctrl_scan_paths(), both of which expect a valid context. Instead of adding NULL checks in each callee, validate @ctx in libnvme_rescan_ctrl() and return early if no valid context is available. This avoids propagating an invalid context to the namespace and path scan helpers. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )