[pull] master from linux-nvme:master#239
Merged
Merged
Conversation
The null check on ctrl was inverted, causing the function to return early on successful allocation and dereference NULL on failure. Fix the condition to correctly check for allocation failure. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
The autoconnect units (nvmf-autoconnect.service and nvmf-connect@.service) run "nvme connect-all" to bring up NVMe-oF controllers at boot and on discovery events. With the ownership registry, a connection made without an owner is recorded as unowned and therefore becomes a target for a plain "nvme disconnect-all". Pass --owner=autoconnect on these invocations so the controllers they create are attributed to the autoconnect machinery and survive an ownership-aware disconnect-all. Coincidentally, --owner=autoconnect lands in the same spot these units once carried --context=autoconnect. The two are unrelated: --context was a config-file filter (match entries by context) that went unused and was removed; --owner attributes the connection in the registry. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )