[pull] master from linux-nvme:master#236
Merged
Merged
Conversation
The hfi_list, security_list, discovery_list, and subsystem_ns_list arrays were allocated using sizeof(struct) instead of sizeof(struct *), which caused memory over-allocation and triggered static analysis warnings. These arrays store pointers to structs, not the structs themselves. Changed to use sizeof(struct *) to allocate the correct amount of memory for pointer arrays. Signed-off-by:Brooke Ellis <Brooke.Ellis@ibm.com>
The result variable was uninitialized before being passed to get_feature_id(). Initialize it to 0 to prevent undefined behavior. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
The flags variable was uninitialized before use in io_passthru(). Initialize it to 0 to prevent undefined behavior. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
The log argument was passed uninitialized to nvme_init_get_log_lba_status(). Pass the allocated buf instead to prevent undefined behavior. Signed-off-by: Fahim Hassan <fahim.hassan@ibm.com>
The Command Specific Status "Request Exceeds Maximum Namespace Sanitize Operations In Progress" is defined as 3Ch in Figure 103 of the NVM Express Base Specification 2.3, but was assigned 0x12, aliasing NVME_SC_FW_NEEDS_MAX_TIME (Firmware Activation Requires Maximum Time Violation). Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
NVME_SC_FEAT_IOCS_COMBINATION_REJECTED was assigned 0x15, aliasing NVME_SC_NS_INSUFFICIENT_CAP, whereas Figure 103 of the NVM Express Base Specification 2.3 defines "I/O Command Set Combination Rejected" as 2Bh. The correctly-numbered NVME_SC_IOCS_COMBINATION_REJECTED (= 0x2b) already exists and represents the same status, so the misnumbered duplicate is redundant. Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
- Cleans up someindentation and text formatting issues - Removes the redundant min definition since min is provided by common.h - Makes timestamp format string platform agnostic. Signed-off-by: Broc Going <bgoing@micron.com>
- Adds micron-utils with separate Linux and Windows implementations. - Adds utility method for getting PCIe ID values which are used to determine drive model. - Removes hard-coded sysfs paths in favor of using libnvme utils to get sysfs paths. Signed-off-by: Broc Going <bgoing@micron.com>
Pulls PCIe AER correctable error managment into utility methods that are implemented appropriately for different platforms. Windows does not support this functionality. Signed-off-by: Broc Going <bgoing@micron.com>
Adds utility method for writing OS configuration information to a file and adds an implementation for Windows. Signed-off-by: Broc Going <bgoing@micron.com>
Updates .zip file generation to support Windows. The Windows version of tar is based on bsdtar, which supports creating zip archives. If the zip command fails, checks to see if tar is bsdtar, and if so, uses it to generate the .zip archive. In powershell on Windows, rm doesn't work with the same parameters as on Linux. Adds new RemoveDirRecursive method to remove directory and temporary file without using rm. Signed-off-by: Broc Going <bgoing@micron.com>
Increments the plugin minor version to reflect the addition of Windows support. Signed-off-by: Broc Going <bgoing@micron.com>
Add nvme_sigint_received wrapper around sleep, so it will exit instead of continue when a SIGINT is received. Signed-off-by: g0l4 <g0l4@g0l4.top>
The upstream kernel commit 37afebc79a11 ("nvme: add diag attribute
group under sysfs") groups all diag attributes under a new directory
/sys/block/.../diag/.
Update the libnvme diag attribute accessors to use the new paths. The
following attributs path have been updated:
- command_retry_count
- command_error_count
- multipath_failover_count
- reset_count
- reconnect_count
A few other diagnostic attributes were also renamed and their paths
updated. Support for those attributes will be added in a subsequent
patch.
These attributes are used by the nvme-top dashboard to display real-time
controller and multipath diagnostic statistics.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
The upstream kernel commit 37afebc79a11 ("nvme: add diag attribute
group under sysfs") groups all diag attributes under a new directory
/sys/block/.../diag/.
In addition, the following attributes were renamed as well as their
path were also changed:
- io_requeue_no_usable_path_count
- io_fail_no_available_path_count
Update the corresponding libnvme attribute names and paths to match the
new sysfs interface. Since the exported accessor names change, update
accessors.i and libnvme.ld accordingly.
These attributes are used by nvme-top, so update nvme-cli to use the
new accessor names.
Signed-off-by: Nilay Shroff <nilay@linux.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )