[pull] master from linux-nvme:master#235
Merged
Merged
Conversation
This is to be consistent with the rest of the commands. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Every other fabrics command spells --transport as -t (via the shared NVMF_ARGS macro), but disconnect-all defined its own option set with -r. -t is the canonical transport short form and is now free on disconnect-all, since --timeout no longer claims a short form, so switch to it for consistency. This is a deliberate break with no -r alias. While here, drop a stray (char *) cast on the option's value argument, matching how the same option is declared elsewhere. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
These commands establish controller connections through libnvme but had no way to record the connecting orchestrator's identity, so every controller they created looked unowned and disconnect-all would tear it down. Add a long-only --owner NAME option that calls libnvme_set_owner() before connecting. For connect-all and discover, --nbft already records owner=nbft so legacy boot scripts get ownership for free. An explicit --owner now overrides that default; a plain --nbft (no --owner) still records nbft, so the boot path is unchanged. --owner has no short form here, and disconnect-all's --owner loses its -O short form to match, so --owner is long-only on every command. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Attribute values are free-form -- only device and attribute names are validated, never the value. Add a test that stores a value containing spaces, double quotes, an apostrophe and punctuation, then confirms it reads back byte-for-byte, so this guarantee cannot regress through accidental escaping or sanitization of the value. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )