[pull] master from linux-nvme:master#233
Merged
Merged
Conversation
Since the option is duplicated with the verbose option. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since the option is duplicated with the verbose option. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since the option is duplicated with the verbose option. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Since the option is duplicated with the verbose option. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
The set of fabrics-only headers appended to the generated libnvme.h was carried as a single \n-escaped string argument to libconf.set() in meson.build. That form is hard to read and easy to get wrong when an include is added or removed. Move the include list into libnvme/src/fabrics-includes.h.in, one directive per line, and pull it in with fs.read(). The generated libnvme.h is unchanged. Suggested-by: Daniel Wagner <wagi@kernel.org> Signed-off-by: Martin Belanger <martin.belanger@dell.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )