[pull] master from linux-nvme:master#228
Merged
Merged
Conversation
The log_level for certain commands like show-topology and tls-key does not get updated even when the verbose option is passed to them. Fix this by ensuring parse_args() is invoked in these commands instead of argconfig_parse(), so that the log_level gets properly updated here. Signed-off-by: Martin George <marting@netapp.com>
Fixes field alignments of the nvme_bar_cap struct by making cps part of the __u16 that was missing those two bits. This change fixes warnings regarding the struct size encountered when compiling on Windows. Signed-off-by: Broc Going <bgoing@micron.com>
This is to make it easier to understand to add. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Use the definition instead of the hardcoded value. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
Newer library is returning a different error code on large chunks. Signed-off-by: Leonardo da Cunha <leonardo.da.cunha@solidigm.com>
Adds a 'top' configuration option that is enabled by default, and makes compilation of nvme-top code conditional on the feature enablement. Disables the top feature by default on Windows due to compatibility issues. Signed-off-by: Broc Going <bgoing@micron.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )