[pull] master from linux-nvme:master#222
Merged
Merged
Conversation
Make the placement of the global options more flexible. This allows the user do something like alias nvme="nvme -v" Signed-off-by: Daniel Wagner <wagi@kernel.org>
The command line parser sets the nvme_args members correctly now. Thus no need to look into the opts. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The command line parser sets the nvme_args members correctly now. Thus no need to look into the opts. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Test the global options placement. Signed-off-by: Daniel Wagner <wagi@kernel.org>
These are the global short options, no plugin should use it, thus rename them. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The global option parser claims the -o and -v short option. Thus plugins can't use them. Signed-off-by: Daniel Wagner <wagi@kernel.org>
compiler complains with:
‘strncpy’ output may be truncated copying 255 bytes from a string of
length 255 [-Werror=stringop-truncation]
277 | strncpy(smart.path, path, sizeof(smart.path) - 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Using snprintf ensures the smart.path is correctly terminated.
Signed-off-by: Daniel Wagner <wagi@kernel.org>
The global options can be place as first optional argument before the command. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Put each command option to a new line to avoid over long lines. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )