[pull] master from linux-nvme:master#212
Merged
Merged
Conversation
Sort the entries alphabetically. Signed-off-by: Daniel Wagner <wagi@kernel.org>
libnvme uses posix_memalign to ensure that allocated memory buffers are properly aligned. This API does not exist on Windows, so move this code into a platform abstraction. Since we have to abstract the same APIs for nvme-cli itself, add these helpers to the libnvme API. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Add Windows implementations of libnvme_alloc, libnvme_realloc, and related memory allocation helpers. This provides a consistent cross-platform memory allocation interface for libnvme on Windows systems. Signed-off-by: Broc Going <bgoing@micron.com> Signed-off-by: Brandon Capener <bcapener@micron.com> [wagi: cherry-picked code, fixed libnvme_realloc] Signed-off-by: Daniel Wagner <wagi@kernel.org>
The library added platform abstraction code for memory allocation. Switch over to this API and remove the duplicated code in nvme-cli. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Move these helpers to the library, so it's abstraction code for the mem API are in one place. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Add Windows support for the huge memory allocation APIs by implementing libnvme_alloc_huge() and libnvme_free_huge() using Windows-specific memory allocation mechanisms. This brings the huge page memory API support closer to feature parity across supported platforms. Signed-off-by: Broc Going <bgoing@micron.com> Signed-off-by: Brandon Capener <bcapener@micron.com> [wagi: cherry picked code] Signed-off-by: Daniel Wagner <wagi@kernel.org>
Introduce libnvme_free as the common deallocation API for memory allocated via libnvme_alloc() and libnvme_realloc(). This completes the basic memory management interface by providing a consistent wrapper for freeing libnvme-managed allocations. Signed-off-by: Daniel Wagner <wagi@kernel.org>
In case reallocarray is not available provide an open-coded version. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Use the library alloc function which ensures that alllocation are propaerly aligned. This avoids a direct dependency on posix_memalign. Signed-off-by: Daniel Wagner <wagi@kernel.org>
It doesn't seem possible to upload the artifacts directly from the job. Move the upload to the dedicated GH action which should be handle this correctly. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Automated security fix generated by Orbis Security AI Signed-off-by: orbisai0security <mediratta01.pally@gmail.com>
Fixes build warnings in private.h when building with fabrics disabled but netdb available. Includes ifaddrs in private.h if needed. Signed-off-by: Broc Going <bgoing@micron.com>
Fixes check-public-headers test with fabrics disabed. Since nbft is not included when fabrics is disabled, moves public nbft methods from libnvme.ld to libnvmf.ld and renames them with the libnvmf prefix. Signed-off-by: Broc Going <bgoing@micron.com>
Update to the current version of the download-artifact. Signed-off-by: Daniel Wagner <wagi@kernel.org>
dprintf is not available on Windows, so open-code it using asprintf and write. Signed-off-by: Daniel Wagner <wagi@kernel.org>
getline is not available on all platforms. Since the UUID input has a fixed and well-defined format, use fgets instead. This avoids the dynamic allocation from getline and improves portability Signed-off-by: Daniel Wagner <wagi@kernel.org>
stdout_effects_log_segment wants to print a header if there are any log entries. This is done using a memstream for - a "did anything print?" detector - plus a temporary accumulation buffer That's overkill here. Refactor this function with the side effect it also portable. Signed-off-by: Daniel Wagner <wagi@kernel.org>
The make the port on Windows simpler replace getline with fgets. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Make the interface easier to use on the callside by asking for the device name instead the id. Signed-off-by: Daniel Wagner <wagi@kernel.org>
Somewhere in the past the support to print the product name was lost. Bring it back. Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )