[pull] master from linux-nvme:master#206
Merged
Merged
Conversation
Documents the PyPI publishing workflow: source distribution only (no wheels), GitHub Actions handles both TestPyPI (on every master push) and PyPI (on release tags), using OIDC authentication. Signed-off-by: Martin Belanger <Martin.Belanger@dell.com>
Replace the connect_err/discover_err globals and %exception shims with
a proper exception hierarchy in libnvme/_exceptions.py:
NvmeError (base, .errno + .message)
├── ConnectError
├── DisconnectError
├── DiscoverError
└── NotConnectedError (.errno is always 0)
Exceptions are imported into the nvme module namespace at init time
via %init %{} and re-exported via %pythoncode so callers can use
nvme.ConnectError etc. directly.
raise_nvme(cls, err) sets the exception from C; raise_not_connected()
handles the no-errno case. SWIG_fail cannot be used inside %extend
function bodies (they are extracted into SWIGINTERN helpers where the
fail: label is absent), so minimal %exception blocks propagate any
pending exception set by the helper back into the wrapper.
Also rename supported_log_pages() to get_supported_log_pages(), which
now raises NvmeError on failure instead of returning None.
Update discover-loop.py and README.md to match the new API.
Signed-off-by: Martin Belanger <Martin.Belanger@dell.com>
These are leftover files no longer needed following the redesign of the python bindings. Signed-off-by: Martin Belanger <martin.belanger@dell.com>
Add two targets for running checkpatch locally before committing: - checkpatch: runs against committed changes (default base: master, overridable via BASE=) - checkpatch-diff: runs against staged/unstaged working-tree changes and any untracked files checkpatch.pl is fetched from torvalds/linux on first use and cached in /tmp, mirroring the CI workflow. Signed-off-by: Martin Belanger <Martin.Belanger@dell.com> Assisted-by: Claude:claude-sonnet-4-6 [Claude Code]
The previous check-accessors workflow only verified accessors.h and
accessors.c via git diff, leaving six generated files unchecked:
accessors.ld, accessors-fabrics.{h,c,ld}, and accessors{,-fabrics}.i.
Add a -Dcheck-accessors=true meson option. When set, update-accessors.sh
runs in read-only CI mode (--check flag): it exits non-zero if any .h/.c/.i
file is stale or if the .ld symbol set has drifted. The .ld check mirrors
the existing developer workflow — symbols are compared rather than the file
contents, because the version-section label requires manual assignment.
The existing update-common-accessors and update-fabrics-accessors targets
gain the --check flag when the option is enabled; no new targets are needed.
The CI workflow passes -Dcheck-accessors=true to meson setup and replaces
the separate git-diff step with a single meson compile update-accessors.
Signed-off-by: Martin Belanger <Martin.Belanger@dell.com>
Assisted-by: Claude:claude-sonnet-4-6 [Claude Code]
We need to specify the devices that are passed though to the VM when running the tests. The kubevirt-action should not be responsible for picking the testing devices. Signed-off-by: Dennis Maisenbacher <dennis.maisenbacher@wdc.com>
The recently added function nvmf_update_tls_concat() dereferences struct nvmf_disc_log_entry *e, but e will always be NULL when called via libnvmf_discovery_nbft(). This can result in a segmentation fault when attempting "nvme connect-all --nbft". Check for NULL pointer before dereferencing. Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com> Link: https://patch.msgid.link/20260506205345.64478-1-stuart.w.hayes@gmail.com Signed-off-by: Daniel Wagner <wagi@kernel.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )